Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT (v2)

2014-08-14 Thread David Miller
From: Andrey Vagin Date: Wed, 13 Aug 2014 16:03:10 +0400 > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > isn't good, because some congestion modules heavily depends on it. > > This patch adds the TCPCB_REPAIRED flag, which is included in > TCPCB_RETRANS. > > Thanks t

[PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT (v2)

2014-08-13 Thread Andrey Vagin
We don't know right timestamp for repaired skb-s. Wrong RTT estimations isn't good, because some congestion modules heavily depends on it. This patch adds the TCPCB_REPAIRED flag, which is included in TCPCB_RETRANS. Thanks to Eric for the advice how to fix this issue. This patch fixes the warnin

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Andrew Vagin
On Tue, Aug 12, 2014 at 07:53:57AM -0700, Yuchung Cheng wrote: > On Tue, Aug 12, 2014 at 2:45 AM, Andrey Vagin wrote: > > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > > isn't good, because some congestion modules heavily depends on it. > > > > This patch adds the TCPCB

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Yuchung Cheng
On Tue, Aug 12, 2014 at 2:45 AM, Andrey Vagin wrote: > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > isn't good, because some congestion modules heavily depends on it. > > This patch adds the TCPCB_REPAIRED flag, which is included in > TCPCB_RETRANS. > > Thanks to Eric

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Andrew Vagin
On Tue, Aug 12, 2014 at 06:14:43AM -0700, Eric Dumazet wrote: > On Tue, 2014-08-12 at 16:33 +0400, Andrew Vagin wrote: > > On Tue, Aug 12, 2014 at 05:15:01AM -0700, Eric Dumazet wrote: > > > On Tue, 2014-08-12 at 13:45 +0400, Andrey Vagin wrote: > > > > We don't know right timestamp for repaired sk

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Eric Dumazet
On Tue, 2014-08-12 at 16:33 +0400, Andrew Vagin wrote: > On Tue, Aug 12, 2014 at 05:15:01AM -0700, Eric Dumazet wrote: > > On Tue, 2014-08-12 at 13:45 +0400, Andrey Vagin wrote: > > > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > > > isn't good, because some congestion m

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Andrew Vagin
On Tue, Aug 12, 2014 at 05:15:01AM -0700, Eric Dumazet wrote: > On Tue, 2014-08-12 at 13:45 +0400, Andrey Vagin wrote: > > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > > isn't good, because some congestion modules heavily depends on it. > > > > This patch adds the TCPC

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Eric Dumazet
On Tue, 2014-08-12 at 13:45 +0400, Andrey Vagin wrote: > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > isn't good, because some congestion modules heavily depends on it. > > This patch adds the TCPCB_REPAIRED flag, which is included in > TCPCB_RETRANS. ... > + > +

[PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Andrey Vagin
We don't know right timestamp for repaired skb-s. Wrong RTT estimations isn't good, because some congestion modules heavily depends on it. This patch adds the TCPCB_REPAIRED flag, which is included in TCPCB_RETRANS. Thanks to Eric for the advice how to fix this issue. This patch fixes the warnin