Re: [PATCH] tcp: keepalive fixes

2021-01-22 Thread Enke Chen
Hi, Folks: Please ignore this patch. I will split it into separate ones as suggested off-list by Neal Cardwell . Thanks. -- Enke On Tue, Jan 12, 2021 at 11:25:44AM -0800, Enke Chen wrote: > From: Enke Chen > > In this patch two issues with TCP keepalives are fixed: > > 1) TCP keepalive does

Re: [PATCH] tcp: keepalive fixes

2021-01-13 Thread Enke Chen
On Wed, Jan 13, 2021 at 12:06:27PM -0800, Enke Chen wrote: > Hi, Eric: > > Just to clarify: the issues for tcp keepalive and TCP_USER_TIMEOUT are > separate isues, and the fixes would not conflict afaik. > > Thanks. -- Enke I have posted patches for both issues, and there is no conflict

Re: [PATCH] tcp: keepalive fixes

2021-01-13 Thread Enke Chen
Hi, Eric: Just to clarify: the issues for tcp keepalive and TCP_USER_TIMEOUT are separate isues, and the fixes would not conflict afaik. Thanks. -- Enke On Tue, Jan 12, 2021 at 11:52:43PM +0100, Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 11:48 PM Yuchung Cheng wrote: > > > > On Tue, Jan

Re: [PATCH] tcp: keepalive fixes

2021-01-12 Thread Enke Chen
Hi, Yuchung: I have attached the python script that reproduces the keepalive issues. The script is a slight modification of the one written by Marek Majkowski: https://github.com/cloudflare/cloudflare-blog/blob/master/2019-09-tcp-keepalives/test-zero.py Please note that only the TCP keepalive

Re: [PATCH] tcp: keepalive fixes

2021-01-12 Thread Eric Dumazet
On Tue, Jan 12, 2021 at 11:48 PM Yuchung Cheng wrote: > > On Tue, Jan 12, 2021 at 2:31 PM Enke Chen wrote: > > > > From: Enke Chen > > > > In this patch two issues with TCP keepalives are fixed: > > > > 1) TCP keepalive does not timeout when there are data waiting to be > >delivered and

Re: [PATCH] tcp: keepalive fixes

2021-01-12 Thread Yuchung Cheng
On Tue, Jan 12, 2021 at 2:31 PM Enke Chen wrote: > > From: Enke Chen > > In this patch two issues with TCP keepalives are fixed: > > 1) TCP keepalive does not timeout when there are data waiting to be >delivered and then the connection got broken. The TCP keepalive >timeout is not

[PATCH] tcp: keepalive fixes

2021-01-12 Thread Enke Chen
From: Enke Chen In this patch two issues with TCP keepalives are fixed: 1) TCP keepalive does not timeout when there are data waiting to be delivered and then the connection got broken. The TCP keepalive timeout is not evaluated in that condition. The fix is to remove the code that