Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Christer Weinigel
On Thu, 03 Jan 2008 17:17:29 +0200 Benny Halevy <[EMAIL PROTECTED]> wrote: > On Jan. 03, 2008, 14:30 +0200, Arnaldo Carvalho de Melo > > Agreed, CodingStyle is not about mindless consistency such as "for > > (" is the right thing, so "list_for_each (" is consistent with it, > > it is about codifyi

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Christer Weinigel
On Thu, 03 Jan 2008 13:34:45 +0100 Tomas Carnecky <[EMAIL PROTECTED]> wrote: > Christer Weinigel wrote: > > By the way, what is the consensus on lines over 80 characters? > > checkpatch complains about the following: > > > > WARNING: line over 80 characters > > #762: FILE: drivers/spi/spi_s3c24xx

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Benny Halevy
On Jan. 03, 2008, 14:30 +0200, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > Em Thu, Jan 03, 2008 at 12:26:10PM +, Christoph Hellwig escreveu: >> On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: >>> We have had some stabs at changing this, but no consensus was reached on

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Tomas Carnecky
Christer Weinigel wrote: By the way, what is the consensus on lines over 80 characters? checkpatch complains about the following: WARNING: line over 80 characters #762: FILE: drivers/spi/spi_s3c24xx_dma.c:720: + printk(KERN_INFO "S3C24xx SPI DMA driver (c) 2007 Nordnav Technologies AB\n")

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 03, 2008 at 12:26:10PM +, Christoph Hellwig escreveu: > On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: > > We have had some stabs at changing this, but no consensus was reached on > > whether it was a "for" or a "function". My memory is of there being > > slightly

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Christoph Hellwig
On Thu, Jan 03, 2008 at 11:10:58AM +, Andy Whitcroft wrote: > We have had some stabs at changing this, but no consensus was reached on > whether it was a "for" or a "function". My memory is of there being > slightly more "without a space" tenders than the other and so it has not > been changed

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread pHilipp Zabel
On Dec 2, 2007 1:03 PM, Christer Weinigel <[EMAIL PROTECTED]> wrote: > Hi Andy, > > you seem to be the last person messing around with checkpatch.pl so I'm > addressing this to you. :-) > > checkpatch complains about the following: > > WARNING: no space between function name and open parenthesis '(

Re: [PATCH] teach checkpatch.pl about list_for_each

2008-01-03 Thread Andy Whitcroft
On Sun, Dec 02, 2007 at 01:03:35PM +0100, Christer Weinigel wrote: > Hi Andy, > > you seem to be the last person messing around with checkpatch.pl so I'm > addressing this to you. :-) > > checkpatch complains about the following: > > WARNING: no space between function name and open parenthesis '

Re: [PATCH] teach checkpatch.pl about list_for_each

2007-12-02 Thread Valdis . Kletnieks
On Sun, 02 Dec 2007 13:03:35 +0100, Christer Weinigel said: > WARNING: no space between function name and open parenthesis '(' > #520: FILE: drivers/spi/spi_s3c24xx_dma.c:478: > + list_for_each_entry (transfer, &message->transfers, transfer_list) { > > which I think is a bit bogus since it

Re: [PATCH] teach checkpatch.pl about list_for_each

2007-12-02 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 02, 2007 at 01:03:35PM +0100, Christer Weinigel escreveu: > Hi Andy, > > you seem to be the last person messing around with checkpatch.pl so I'm > addressing this to you. :-) > > checkpatch complains about the following: > > WARNING: no space between function name and open parenthesi

[PATCH] teach checkpatch.pl about list_for_each

2007-12-02 Thread Christer Weinigel
Hi Andy, you seem to be the last person messing around with checkpatch.pl so I'm addressing this to you. :-) checkpatch complains about the following: WARNING: no space between function name and open parenthesis '(' #520: FILE: drivers/spi/spi_s3c24xx_dma.c:478: + list_for_each_entry (tran