Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 11:49 -0700, Nick Desaulniers wrote: > On Wed, Aug 28, 2019 at 1:53 AM Zhang Rui > wrote: > > > > On Mon, 2019-08-19 at 10:21 +0200, Miquel Raynal wrote: > > > Hello, > > > > > > Daniel Lezcano wrote on Thu, 15 Aug > > > 2019 > > > 01:06:21 +0200: > > > > > > > On 15/08/2

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-28 Thread Nick Desaulniers
On Wed, Aug 28, 2019 at 1:53 AM Zhang Rui wrote: > > On Mon, 2019-08-19 at 10:21 +0200, Miquel Raynal wrote: > > Hello, > > > > Daniel Lezcano wrote on Thu, 15 Aug 2019 > > 01:06:21 +0200: > > > > > On 15/08/2019 00:12, Nick Desaulniers wrote: > > > > On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huck

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-28 Thread Zhang Rui
On Mon, 2019-08-19 at 10:21 +0200, Miquel Raynal wrote: > Hello, > > Daniel Lezcano wrote on Thu, 15 Aug 2019 > 01:06:21 +0200: > > > On 15/08/2019 00:12, Nick Desaulniers wrote: > > > On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang > > > Built > > > Linux wrote: > > > > > >

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-19 Thread Miquel Raynal
Hello, Daniel Lezcano wrote on Thu, 15 Aug 2019 01:06:21 +0200: > On 15/08/2019 00:12, Nick Desaulniers wrote: > > On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang Built > > Linux wrote: > >> > >> Following up to see if this patch is going to be accepted. > > > > Miquel is l

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-14 Thread Daniel Lezcano
On 15/08/2019 00:12, Nick Desaulniers wrote: > On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: >> >> Following up to see if this patch is going to be accepted. > > Miquel is listed as the maintainer of this file in MAINTAINERS. > Miquel, can you please pick th

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-14 Thread Nick Desaulniers
On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang Built Linux wrote: > > Following up to see if this patch is going to be accepted. Miquel is listed as the maintainer of this file in MAINTAINERS. Miquel, can you please pick this up? Otherwise Zhang, Eduardo, and Daniel are listed a

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-13 Thread Nathan Huckleberry
Following up to see if this patch is going to be accepted.

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-06-14 Thread Daniel Lezcano
On 13/06/2019 20:49, Nathan Huckleberry wrote: > Clang produces the following warning > > drivers/thermal/armada_thermal.c:270:33: warning: shifting a negative > signed value is undefined [-Wshift-negative-value] > 1 warningreg &= ~CONTROL1_TSEN_AVG_MASK << > CONTROL1_TSEN_AVG_SHIFT; gener

[PATCH] thermal: armada: Fix -Wshift-negative-value

2019-06-13 Thread Nathan Huckleberry
Clang produces the following warning drivers/thermal/armada_thermal.c:270:33: warning: shifting a negative signed value is undefined [-Wshift-negative-value] 1 warningreg &= ~CONTROL1_TSEN_AVG_MASK << CONTROL1_TSEN_AVG_SHIFT; generated . ~~~ ^ CONTROL1_T