Re: [PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

2019-01-29 Thread Phil Elwell
Hi Stefan, On 29/01/2019 09:44, Stefan Wahren wrote: > Hi Phil, > > Am 29.01.2019 um 10:10 schrieb Phil Elwell: >> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer >> dereference in bcm2835_thermal_debugfs. The driver makes use of the >> implementation details of the thermal f

Re: [PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

2019-01-29 Thread Phil Elwell
Hi Daniel, On 29/01/2019 09:52, Daniel Lezcano wrote: > On 29/01/2019 10:10, Phil Elwell wrote: >> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer >> dereference in bcm2835_thermal_debugfs. The driver makes use of the >> implementation details of the thermal framework to retri

Re: [PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

2019-01-29 Thread Daniel Lezcano
On 29/01/2019 10:10, Phil Elwell wrote: > "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer > dereference in bcm2835_thermal_debugfs. The driver makes use of the > implementation details of the thermal framework to retrieve a pointer > to its private data from a struct thermal_zo

[PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

2019-01-29 Thread Phil Elwell
"cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer dereference in bcm2835_thermal_debugfs. The driver makes use of the implementation details of the thermal framework to retrieve a pointer to its private data from a struct thermal_zone_device, and gets it wrong - leading to the cr

Re: [PATCH] thermal: bcm2835: enable hwmon explicitly

2018-11-07 Thread Stefan Wahren
Hi Rui, hi Eduardo, hi Daniel, > matthias@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben: > > > From: Matthias Brugger > > By defaul of-based thermal driver do not enable hwmon. > This patch does this explicitly, so that the temperature can be read > through the common hwmon sysfs

Re: [PATCH] thermal: bcm2835: enable hwmon explicitly

2018-10-23 Thread Matthias Brugger
Hi Stefan, On 23/10/2018 14:01, Stefan Wahren wrote: > Hi Matthias, > >> matthias@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben: >> >> >> From: Matthias Brugger >> >> By defaul of-based thermal driver do not enable hwmon. >> This patch does this explicitly, so that the temperature

Re: [PATCH] thermal: bcm2835: enable hwmon explicitly

2018-10-23 Thread Stefan Wahren
Hi Matthias, > matthias@kernel.org hat am 21. Oktober 2018 um 23:58 geschrieben: > > > From: Matthias Brugger > > By defaul of-based thermal driver do not enable hwmon. > This patch does this explicitly, so that the temperature can be read > through the common hwmon sysfs. > > Signed-off-

[PATCH] thermal: bcm2835: enable hwmon explicitly

2018-10-21 Thread matthias . bgg
From: Matthias Brugger By defaul of-based thermal driver do not enable hwmon. This patch does this explicitly, so that the temperature can be read through the common hwmon sysfs. Signed-off-by: Matthias Brugger --- drivers/thermal/broadcom/bcm2835_thermal.c | 11 +++ 1 file changed, 11

[PATCH] thermal: bcm2835:

2017-06-23 Thread Christophe JAILLET
'tz' is a valid pointer at this point, so calling PTR_ERR on it is pointless. This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. So remove it. 'err' is already the error we want to report. Signed-off-by: Christophe JAILLET --- drivers/thermal/broadcom/bcm2835_thermal.c | 1