Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Eduardo Valentin
On 09-04-2013 14:27, Andrew Bresticker wrote: You do two things in this change on cpu_cooling.c: (1) fix the case where the loop is kept running indefinitely. (2) Reserve a specific role for each index in this function. So the issue is that the changes are not independent. With just the fix fo

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Andrew Bresticker
> You do two things in this change on cpu_cooling.c: (1) fix the case where > the loop is kept running indefinitely. (2) Reserve a specific role for each > index in this function. So the issue is that the changes are not independent. With just the fix for the infinite loop, get_cpu_frequency() is

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Eduardo Valentin
On 09-04-2013 13:02, Andrew Bresticker wrote: Hi Eduardo, On Tue, Apr 9, 2013 at 7:55 AM, Eduardo Valentin wrote: Hi Andrew, On 08-04-2013 19:54, Andrew Bresticker wrote: The loops which are used to perform lookups in CPU frequency tables in cpu_cooling and the Exynos thermal driver do not

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Andrew Bresticker
Hi Eduardo, On Tue, Apr 9, 2013 at 7:55 AM, Eduardo Valentin wrote: > Hi Andrew, > > > On 08-04-2013 19:54, Andrew Bresticker wrote: >> >> The loops which are used to perform lookups in CPU frequency tables in >> cpu_cooling and the Exynos thermal driver do not update the loop counter >> if they

Re: [PATCH] thermal: fix frequency table lookup bugs

2013-04-09 Thread Eduardo Valentin
Hi Andrew, On 08-04-2013 19:54, Andrew Bresticker wrote: The loops which are used to perform lookups in CPU frequency tables in cpu_cooling and the Exynos thermal driver do not update the loop counter if they encounter an invalid table entry, leading to an infinite loop in that case. Signed-off

[PATCH] thermal: fix frequency table lookup bugs

2013-04-08 Thread Andrew Bresticker
The loops which are used to perform lookups in CPU frequency tables in cpu_cooling and the Exynos thermal driver do not update the loop counter if they encounter an invalid table entry, leading to an infinite loop in that case. Signed-off-by: Andrew Bresticker --- drivers/thermal/cpu_cooling.c