Re: [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-10 Thread Zhang Rui
On Mon, 2017-08-07 at 23:35 -0500, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the rockchip_thermal > driver > ignores it and always returns -EINVAL. This is not correct and, > prevents > -EPROBE_DEFER from being propagated properly. > > Notice that

Re: [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-10 Thread Zhang Rui
On Mon, 2017-08-07 at 23:35 -0500, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the rockchip_thermal > driver > ignores it and always returns -EINVAL. This is not correct and, > prevents > -EPROBE_DEFER from being propagated properly. > > Notice that

[PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-07 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the rockchip_thermal driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error:

[PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-07 Thread Gustavo A. R. Silva
platform_get_irq() returns an error code, but the rockchip_thermal driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: