Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-11 Thread Zhang Rui
On Wed, 2013-04-10 at 16:22 -0400, Eduardo Valentin wrote: > On 10-04-2013 03:06, Zhang Rui wrote: > > On Tue, 2013-04-09 at 14:59 -0700, Andrew Bresticker wrote: > >> When selecting a target cooling state in get_target_state(), make sure > >> that the state is at least as high as the minimum when

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-10 Thread Eduardo Valentin
On 10-04-2013 03:06, Zhang Rui wrote: On Tue, 2013-04-09 at 14:59 -0700, Andrew Bresticker wrote: When selecting a target cooling state in get_target_state(), make sure that the state is at least as high as the minimum when the temperature is rising and at least as low as the maximum when the te

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-10 Thread Zhang Rui
On Tue, 2013-04-09 at 14:59 -0700, Andrew Bresticker wrote: > When selecting a target cooling state in get_target_state(), make sure > that the state is at least as high as the minimum when the temperature > is rising and at least as low as the maximum when the temperature is > falling. This is ne

[PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-09 Thread Andrew Bresticker
When selecting a target cooling state in get_target_state(), make sure that the state is at least as high as the minimum when the temperature is rising and at least as low as the maximum when the temperature is falling. This is necessary because, in the THREAML_TREND_RAISING and THERMAL_TREND_DROP

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-09 Thread Eduardo Valentin
On 09-04-2013 13:09, Andrew Bresticker wrote: Hi Eduardo, On Tue, Apr 9, 2013 at 8:00 AM, Eduardo Valentin wrote: Hi Andrew, On 08-04-2013 19:56, Andrew Bresticker wrote: When selecting a target cooling state in get_target_state(), make sure that the state is at least as high as the minimu

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-09 Thread Andrew Bresticker
Hi Eduardo, On Tue, Apr 9, 2013 at 8:00 AM, Eduardo Valentin wrote: > Hi Andrew, > > > On 08-04-2013 19:56, Andrew Bresticker wrote: >> >> When selecting a target cooling state in get_target_state(), make sure >> that the state is at least as high as the minimum when the temperature >> is rising

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-09 Thread Eduardo Valentin
Hi Andrew, On 08-04-2013 19:56, Andrew Bresticker wrote: When selecting a target cooling state in get_target_state(), make sure that the state is at least as high as the minimum when the temperature is rising and at least as low as the maximum when the temperature is falling. Previously the coo

[PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-08 Thread Andrew Bresticker
When selecting a target cooling state in get_target_state(), make sure that the state is at least as high as the minimum when the temperature is rising and at least as low as the maximum when the temperature is falling. Previously the cooling level would only be incremented or decremented by one i