Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-12-04 Thread Julia Lawall
On Mon, 4 Dec 2017, Eduardo Valentin wrote: > On Mon, Jul 17, 2017 at 04:42:38PM +0200, Julia Lawall wrote: > > > > > > On Mon, 17 Jul 2017, Jon Hunter wrote: > > > > > > > > On 15/07/17 09:42, Julia Lawall wrote: > > > > Device node iterators perform an of_node_put on each iteration, so > > >

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-12-04 Thread Julia Lawall
On Mon, 4 Dec 2017, Eduardo Valentin wrote: > On Mon, Jul 17, 2017 at 04:42:38PM +0200, Julia Lawall wrote: > > > > > > On Mon, 17 Jul 2017, Jon Hunter wrote: > > > > > > > > On 15/07/17 09:42, Julia Lawall wrote: > > > > Device node iterators perform an of_node_put on each iteration, so > > >

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-12-04 Thread Eduardo Valentin
On Mon, Jul 17, 2017 at 04:42:38PM +0200, Julia Lawall wrote: > > > On Mon, 17 Jul 2017, Jon Hunter wrote: > > > > > On 15/07/17 09:42, Julia Lawall wrote: > > > Device node iterators perform an of_node_put on each iteration, so putting > > > an of_node_put before a continue results in a double

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-12-04 Thread Eduardo Valentin
On Mon, Jul 17, 2017 at 04:42:38PM +0200, Julia Lawall wrote: > > > On Mon, 17 Jul 2017, Jon Hunter wrote: > > > > > On 15/07/17 09:42, Julia Lawall wrote: > > > Device node iterators perform an of_node_put on each iteration, so putting > > > an of_node_put before a continue results in a double

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-07-17 Thread Julia Lawall
On Mon, 17 Jul 2017, Jon Hunter wrote: > > On 15/07/17 09:42, Julia Lawall wrote: > > Device node iterators perform an of_node_put on each iteration, so putting > > an of_node_put before a continue results in a double put. > > > > The semantic match that finds this problem is as follows > >

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-07-17 Thread Julia Lawall
On Mon, 17 Jul 2017, Jon Hunter wrote: > > On 15/07/17 09:42, Julia Lawall wrote: > > Device node iterators perform an of_node_put on each iteration, so putting > > an of_node_put before a continue results in a double put. > > > > The semantic match that finds this problem is as follows > >

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-07-17 Thread Jon Hunter
On 15/07/17 09:42, Julia Lawall wrote: > Device node iterators perform an of_node_put on each iteration, so putting > an of_node_put before a continue results in a double put. > > The semantic match that finds this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression

Re: [PATCH] thermal: tegra: delete unneeded of_node_put

2017-07-17 Thread Jon Hunter
On 15/07/17 09:42, Julia Lawall wrote: > Device node iterators perform an of_node_put on each iteration, so putting > an of_node_put before a continue results in a double put. > > The semantic match that finds this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression

[PATCH] thermal: tegra: delete unneeded of_node_put

2017-07-15 Thread Julia Lawall
Device node iterators perform an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression e1; local idexpression child; iterator name

[PATCH] thermal: tegra: delete unneeded of_node_put

2017-07-15 Thread Julia Lawall
Device node iterators perform an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression e1; local idexpression child; iterator name