RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Zhang, Rui
: Zhang, Rui <rui.zh...@intel.com>; thierry.red...@gmail.com; > mikko.perttu...@kapsi.fi; Eduardo Valentin <edubez...@gmail.com> > Cc: Matt Longnecker <mlongnec...@nvidia.com>; swar...@wwwdotorg.org; > linux-te...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject

RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Zhang, Rui
: Zhang, Rui ; thierry.red...@gmail.com; > mikko.perttu...@kapsi.fi; Eduardo Valentin > Cc: Matt Longnecker ; swar...@wwwdotorg.org; > linux-te...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature > Importance: Hig

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Wei Ni
y.red...@gmail.com; Zhang, Rui <rui.zh...@intel.com>; >> mikko.perttu...@kapsi.fi >> Cc: Matt Longnecker <mlongnec...@nvidia.com>; swar...@wwwdotorg.org; >> linux-te...@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bi

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Wei Ni
gt; mikko.perttu...@kapsi.fi >> Cc: Matt Longnecker ; swar...@wwwdotorg.org; >> linux-te...@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature >> Importance: High >> >> Hi, Rui and Thierry >&

RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Zhang, Rui
ay, March 07, 2016 4:26 PM > To: thierry.red...@gmail.com; Zhang, Rui <rui.zh...@intel.com>; > mikko.perttu...@kapsi.fi > Cc: Matt Longnecker <mlongnec...@nvidia.com>; swar...@wwwdotorg.org; > linux-te...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATC

RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Zhang, Rui
ay, March 07, 2016 4:26 PM > To: thierry.red...@gmail.com; Zhang, Rui ; > mikko.perttu...@kapsi.fi > Cc: Matt Longnecker ; swar...@wwwdotorg.org; > linux-te...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature &g

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Wei Ni
On 2016年03月07日 16:38, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Feb 29, 2016 at 05:51:20PM +0800, Wei Ni wrote: >> The sign bit of temperature readback is bit 0, not bit 1. >> Change to BIT(0) to fix it. >> >> Signed-off-by: Wei Ni >> --- >>

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Wei Ni
On 2016年03月07日 16:38, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Feb 29, 2016 at 05:51:20PM +0800, Wei Ni wrote: >> The sign bit of temperature readback is bit 0, not bit 1. >> Change to BIT(0) to fix it. >> >> Signed-off-by: Wei Ni >> --- >>

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Thierry Reding
On Mon, Feb 29, 2016 at 05:51:20PM +0800, Wei Ni wrote: > The sign bit of temperature readback is bit 0, not bit 1. > Change to BIT(0) to fix it. > > Signed-off-by: Wei Ni > --- > drivers/thermal/tegra_soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Thierry Reding
On Mon, Feb 29, 2016 at 05:51:20PM +0800, Wei Ni wrote: > The sign bit of temperature readback is bit 0, not bit 1. > Change to BIT(0) to fix it. > > Signed-off-by: Wei Ni > --- > drivers/thermal/tegra_soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Thierry Reding
On Wed, Mar 02, 2016 at 04:08:33PM -0800, Matt Longnecker wrote: > > > On 03/01/2016 11:40 PM, Wei Ni wrote: > >>diff --git a/drivers/thermal/tegra_soctherm.c > >>b/drivers/thermal/tegra_soctherm.c > >>index 74ea5765938b..136975220c92 100644 > >>--- a/drivers/thermal/tegra_soctherm.c > >>+++

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Thierry Reding
On Wed, Mar 02, 2016 at 04:08:33PM -0800, Matt Longnecker wrote: > > > On 03/01/2016 11:40 PM, Wei Ni wrote: > >>diff --git a/drivers/thermal/tegra_soctherm.c > >>b/drivers/thermal/tegra_soctherm.c > >>index 74ea5765938b..136975220c92 100644 > >>--- a/drivers/thermal/tegra_soctherm.c > >>+++

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Wei Ni
Hi, Rui and Thierry Could you please take a look at this patch? Thanks. Wei. On 2016年03月03日 08:08, Matt Longnecker wrote: > > > On 03/01/2016 11:40 PM, Wei Ni wrote: >> >diff --git a/drivers/thermal/tegra_soctherm.c >> >b/drivers/thermal/tegra_soctherm.c >> >index 74ea5765938b..136975220c92

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-07 Thread Wei Ni
Hi, Rui and Thierry Could you please take a look at this patch? Thanks. Wei. On 2016年03月03日 08:08, Matt Longnecker wrote: > > > On 03/01/2016 11:40 PM, Wei Ni wrote: >> >diff --git a/drivers/thermal/tegra_soctherm.c >> >b/drivers/thermal/tegra_soctherm.c >> >index 74ea5765938b..136975220c92

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-02 Thread Matt Longnecker
On 03/01/2016 11:40 PM, Wei Ni wrote: >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c >index 74ea5765938b..136975220c92 100644 >--- a/drivers/thermal/tegra_soctherm.c >+++ b/drivers/thermal/tegra_soctherm.c >@@ -57,7 +57,7 @@ > #define READBACK_VALUE_MASK

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-02 Thread Matt Longnecker
On 03/01/2016 11:40 PM, Wei Ni wrote: >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c >index 74ea5765938b..136975220c92 100644 >--- a/drivers/thermal/tegra_soctherm.c >+++ b/drivers/thermal/tegra_soctherm.c >@@ -57,7 +57,7 @@ > #define READBACK_VALUE_MASK

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-01 Thread Wei Ni
Hi, Rui & Thierry & Matt Could you please take a look on this patch. It's a bug on the temperature's sign bit, it can't show the negative temperature, although it will not cause problems for now. Thanks. Wei. On 2016年02月29日 17:51, Wei Ni wrote: > The sign bit of temperature readback is bit 0,

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-03-01 Thread Wei Ni
Hi, Rui & Thierry & Matt Could you please take a look on this patch. It's a bug on the temperature's sign bit, it can't show the negative temperature, although it will not cause problems for now. Thanks. Wei. On 2016年02月29日 17:51, Wei Ni wrote: > The sign bit of temperature readback is bit 0,

[PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-02-29 Thread Wei Ni
The sign bit of temperature readback is bit 0, not bit 1. Change to BIT(0) to fix it. Signed-off-by: Wei Ni --- drivers/thermal/tegra_soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/tegra_soctherm.c

[PATCH] thermal: tegra_soctherm: fix sign bit of temperature

2016-02-29 Thread Wei Ni
The sign bit of temperature readback is bit 0, not bit 1. Change to BIT(0) to fix it. Signed-off-by: Wei Ni --- drivers/thermal/tegra_soctherm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c index