Re: [PATCH] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Mukesh Ojha
On 3/19/2019 10:52 PM, Aditya Pakki wrote: ida_simple_get on failure can return an error. The patch ensures that the dev_set_name is set on non failure cases. Signed-off-by: Aditya Pakki --- We should add check against `ida_simple_get` instead of svc->id >= 0 and clean up  svc. Also,

Re: [PATCH] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Mika Westerberg
On Tue, Mar 19, 2019 at 12:22:59PM -0500, Aditya Pakki wrote: > ida_simple_get on failure can return an error. The patch ensures that > the dev_set_name is set on non failure cases. > > Signed-off-by: Aditya Pakki > --- > drivers/thunderbolt/xdomain.c | 4 +++- > 1 file changed, 3

[PATCH] thunderbolt: Fix to check return value of ida_simple_get

2019-03-19 Thread Aditya Pakki
ida_simple_get on failure can return an error. The patch ensures that the dev_set_name is set on non failure cases. Signed-off-by: Aditya Pakki --- drivers/thunderbolt/xdomain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thunderbolt/xdomain.c

[PATCH] thunderbolt: Fix to check return value of ida_simple_get

2019-03-19 Thread Aditya Pakki
ida_simple_get on failure can return an error. The patch ensures that the dev_set_name is set on non failure cases. Signed-off-by: Aditya Pakki --- drivers/thunderbolt/xdomain.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thunderbolt/xdomain.c