Re: [PATCH] thunderbolt: Make priority unsigned in struct tb_path

On Wed, Apr 24, 2019 at 12:00:05PM -0700, Nathan Chancellor wrote: > On Wed, Apr 24, 2019 at 11:49:37AM -0700, Nick Desaulniers wrote: > > On Wed, Apr 24, 2019 at 11:34 AM Nathan Chancellor > > wrote: > > > > > > Clang warns: > > > > > > drivers/thunderbolt/tunnel.c:504:17: warning: implicit trunc

Re: [PATCH] thunderbolt: Make priority unsigned in struct tb_path

On Wed, Apr 24, 2019 at 12:00 PM Nathan Chancellor wrote: > > > Furthmore, that value is only assigned to an unsigned integer in > > Although apparently I can't spell... should be "Furthermore". :set spell there's probably a way to autoset this for commit messages. -- Thanks, ~Nick Desaulniers

Re: [PATCH] thunderbolt: Make priority unsigned in struct tb_path

On Wed, Apr 24, 2019 at 11:49:37AM -0700, Nick Desaulniers wrote: > On Wed, Apr 24, 2019 at 11:34 AM Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/thunderbolt/tunnel.c:504:17: warning: implicit truncation from > > 'int' to bit-field changes value from 5 to -3 > > [-Wbitfield-cons

Re: [PATCH] thunderbolt: Make priority unsigned in struct tb_path

On Wed, Apr 24, 2019 at 11:34 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/thunderbolt/tunnel.c:504:17: warning: implicit truncation from > 'int' to bit-field changes value from 5 to -3 > [-Wbitfield-constant-conversion] > path->priority = 5; >^ ~ > 1 wa

[PATCH] thunderbolt: Make priority unsigned in struct tb_path

Clang warns: drivers/thunderbolt/tunnel.c:504:17: warning: implicit truncation from 'int' to bit-field changes value from 5 to -3 [-Wbitfield-constant-conversion] path->priority = 5; ^ ~ 1 warning generated. The priority member in struct tb_path is only ever assigne