Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-25 Thread Al Viro
On Thu, Oct 25, 2012 at 09:31:31AM -0400, Chris Metcalf wrote: > On 10/23/2012 4:36 PM, Al Viro wrote: > > Could you test the following on top of your patch? It gets rid of > > regs use in sys_clone() *and* of the regs argument in copy_thread(). > > If that work (including SMP - note that it chang

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-25 Thread Chris Metcalf
On 10/23/2012 4:36 PM, Al Viro wrote: > Could you test the following on top of your patch? It gets rid of > regs use in sys_clone() *and* of the regs argument in copy_thread(). > If that work (including SMP - note that it changes the path taken > by copy_thread() when called by fork_idle()), that

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-24 Thread Catalin Marinas
On Tue, Oct 23, 2012 at 10:22:45PM +0100, Jeff King wrote: > On Tue, Oct 23, 2012 at 10:09:46PM +0100, Catalin Marinas wrote: > > > It is spelled: > > > > > > git notes add -m SHA1 > > > > > > The resulting notes are stored in a separate revision-controlled branch > > > and can be pushed and pul

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Johannes Sixt
Am 10/24/2012 0:23, schrieb Jeff King: > For the fold-on-rebase idea, I'd think you would want something similar, > like setting rebase.foldNotes to "foo" to say "refs/notes/foo contains > pseudo-headers that should be folded in like a signed-off-by". If you are rebasing anyway, you can already us

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Ingo Molnar
* Linus Torvalds wrote: > On Wed, Oct 24, 2012 at 12:25 AM, Thomas Gleixner wrote: > >> > >> It is spelled: > >> > >> git notes add -m SHA1 > > > > Cool! > > Don't use them for anything global. > > Use them for local codeflow, but don't expect them to be > distributed. It's a separate "fl

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Linus Torvalds
On Wed, Oct 24, 2012 at 4:56 AM, Al Viro wrote: > > How about git commit --allow-empty, with > "belated ACK for Don't bother. It's not that important, and it's just distracting. It's not like this is vital information. If you pushed it out without the ack, it's out without the ack. Big deal.

RE: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Marc Gauthier
Jeff King wrote: > On Tue, Oct 23, 2012 at 11:25:06PM +0200, Thomas Gleixner wrote: > > > The resulting notes are stored in a separate > > > revision-controlled branch > > > > Which branch(es) is/are that ? What are the semantics of that? [...] Nice feature. Can a later commit be eventually be m

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Al Viro
On Wed, Oct 24, 2012 at 04:02:49AM +0300, Linus Torvalds wrote: > On Wed, Oct 24, 2012 at 12:25 AM, Thomas Gleixner wrote: > >> > >> It is spelled: > >> > >> git notes add -m SHA1 > > > > Cool! > > Don't use them for anything global. > > Use them for local codeflow, but don't expect them to b

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Linus Torvalds
On Wed, Oct 24, 2012 at 12:25 AM, Thomas Gleixner wrote: >> >> It is spelled: >> >> git notes add -m SHA1 > > Cool! Don't use them for anything global. Use them for local codeflow, but don't expect them to be distributed. It's a separate "flow", and while it *can* be distributed, it's not goi

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Jeff King
On Tue, Oct 23, 2012 at 03:06:59PM -0700, Marc Gauthier wrote: > Can a later commit be eventually be made to reference some set > of notes added so far, so they become part of the whole history > signed by the HEAD SHA1? hence pulled/pushed automatically as > well. Otherwise do you not end up wi

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Jeff King
On Tue, Oct 23, 2012 at 11:25:06PM +0200, Thomas Gleixner wrote: > > The resulting notes are stored in a separate revision-controlled branch > > Which branch(es) is/are that ? What are the semantics of that? They are stored in refs/notes/commits by default, but you can have multiple notes refs i

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Thomas Gleixner
On Tue, 23 Oct 2012, Jeff King wrote: > On Tue, Oct 23, 2012 at 10:47:28PM +0200, Thomas Gleixner wrote: > > > I agree that this is a common issue. Acked-by/Reviewed-by mails come > > in after the fact that the patch has been committed to an immutable > > (i.e no-rebase mode) branch or if the cha

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Jeff King
On Tue, Oct 23, 2012 at 10:09:46PM +0100, Catalin Marinas wrote: > > It is spelled: > > > > git notes add -m SHA1 > > > > The resulting notes are stored in a separate revision-controlled branch > > and can be pushed and pulled like regular refs. Note, though, that the > > default refspecs do no

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Catalin Marinas
On 23 October 2012 21:51, Jeff King wrote: > On Tue, Oct 23, 2012 at 10:47:28PM +0200, Thomas Gleixner wrote: > >> I agree that this is a common issue. Acked-by/Reviewed-by mails come >> in after the fact that the patch has been committed to an immutable >> (i.e no-rebase mode) branch or if the ch

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Jeff King
On Tue, Oct 23, 2012 at 10:47:28PM +0200, Thomas Gleixner wrote: > I agree that this is a common issue. Acked-by/Reviewed-by mails come > in after the fact that the patch has been committed to an immutable > (i.e no-rebase mode) branch or if the change in question already hit > Linus tree. > > St

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Thomas Gleixner
On Tue, 23 Oct 2012, Al Viro wrote: > On Tue, Oct 23, 2012 at 01:30:26PM -0400, Chris Metcalf wrote: > > > I fetched the series from your arch-tile branch and built it, and it works > > fine. It looks good from my inspection: > > > > Acked-by: Chris Metcalf > > Thanks; Acked-by applied, branch

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Al Viro
On Tue, Oct 23, 2012 at 03:22:36PM -0400, Chris Metcalf wrote: > On 10/23/2012 2:41 PM, Al Viro wrote: > > On Tue, Oct 23, 2012 at 01:30:26PM -0400, Chris Metcalf wrote: > >> As you had suggested in an earlier email, I went ahead and eliminated the > >> special pt_regs handling for sigaltstack, rt_

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Chris Metcalf
On 10/23/2012 2:41 PM, Al Viro wrote: > On Tue, Oct 23, 2012 at 01:30:26PM -0400, Chris Metcalf wrote: >> As you had suggested in an earlier email, I went ahead and eliminated the >> special pt_regs handling for sigaltstack, rt_sigreturn, and clone. (Also a >> tilepro-specific syscall that was als

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Al Viro
On Tue, Oct 23, 2012 at 01:30:26PM -0400, Chris Metcalf wrote: > I fetched the series from your arch-tile branch and built it, and it works > fine. It looks good from my inspection: > > Acked-by: Chris Metcalf Thanks; Acked-by applied, branch pushed and put into no-rebase mode. BTW, something

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-23 Thread Chris Metcalf
On 10/20/2012 1:16 PM, Al Viro wrote: > On Sat, Oct 20, 2012 at 04:34:01PM +0100, Al Viro wrote: >> On Sat, Oct 20, 2012 at 09:06:57AM -0400, Chris Metcalf wrote: >>> First, the compat_sys_execve() declaration provided in >>> arch/tile/include/asm/compat.h isn't right, so I deleted that (you had on

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-22 Thread Catalin Marinas
Hi Al, Sorry, couldn't reply earlier. On Sat, Oct 20, 2012 at 04:34:01PM +0100, Al Viro wrote: > On Sat, Oct 20, 2012 at 09:06:57AM -0400, Chris Metcalf wrote: > > First, the compat_sys_execve() declaration provided in > > arch/tile/include/asm/compat.h isn't right, so I deleted that (you had onl

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-20 Thread Al Viro
On Sat, Oct 20, 2012 at 04:34:01PM +0100, Al Viro wrote: > On Sat, Oct 20, 2012 at 09:06:57AM -0400, Chris Metcalf wrote: > > First, the compat_sys_execve() declaration provided in > > arch/tile/include/asm/compat.h isn't right, so I deleted that (you had only > > deleted the PTREGS_SYSCALL trampol

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-20 Thread Al Viro
On Sat, Oct 20, 2012 at 09:06:57AM -0400, Chris Metcalf wrote: > First, the compat_sys_execve() declaration provided in > arch/tile/include/asm/compat.h isn't right, so I deleted that (you had only > deleted the PTREGS_SYSCALL trampoline declaration, _compat_sys_execve). > > However, then arch/til

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-20 Thread Chris Metcalf
On 10/19/2012 5:35 PM, Al Viro wrote: > On Fri, Oct 19, 2012 at 04:25:12PM -0400, Chris Metcalf wrote: >> Also provide an optimized current_pt_regs() while we're at it. > Applied. BTW, are you sure you want to record parent's pid and not tid? By recording ->pid rather than ->pgid, we ARE recordin

Re: [PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-19 Thread Al Viro
On Fri, Oct 19, 2012 at 04:25:12PM -0400, Chris Metcalf wrote: > Also provide an optimized current_pt_regs() while we're at it. Applied. BTW, are you sure you want to record parent's pid and not tid? Anyway, here's a followup on top of this one (again, completely untested) - switching to generic

[PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-19 Thread Chris Metcalf
Also provide an optimized current_pt_regs() while we're at it. Signed-off-by: Chris Metcalf --- [Re-sending to correct linus-arch / linux-arch typo.] arch/tile/Kconfig |2 + arch/tile/include/asm/processor.h |3 ++ arch/tile/include/asm/switch_to.h |5 +- arch/tile/k

[PATCH] tile: support GENERIC_KERNEL_THREAD and GENERIC_KERNEL_EXECVE

2012-10-19 Thread Chris Metcalf
Also provide an optimized current_pt_regs() while we're at it. Signed-off-by: Chris Metcalf --- arch/tile/Kconfig |2 + arch/tile/include/asm/processor.h |3 ++ arch/tile/include/asm/switch_to.h |5 +- arch/tile/kernel/entry.S | 11 arch/tile/kernel/in