Re: [PATCH] time: Avoid signed overflow in timekeeping_get_ns()

2015-12-04 Thread John Stultz
On Sun, Nov 29, 2015 at 5:30 PM, David Gibson wrote: > 1e75fa8 "time: Condense timekeeper.xtime into xtime_sec" replaced a call to > clocksource_cyc2ns() from timekeeping_get_ns() with an open-coded version > of the same logic to avoid keeping a semi-redundant struct timespec > in struct timekeepe

Re: [PATCH] time: Avoid signed overflow in timekeeping_get_ns()

2015-11-30 Thread Laurent Vivier
On 30/11/2015 02:30, David Gibson wrote: > 1e75fa8 "time: Condense timekeeper.xtime into xtime_sec" replaced a call to > clocksource_cyc2ns() from timekeeping_get_ns() with an open-coded version > of the same logic to avoid keeping a semi-redundant struct timespec > in struct timekeeper. > > How

[PATCH] time: Avoid signed overflow in timekeeping_get_ns()

2015-11-29 Thread David Gibson
1e75fa8 "time: Condense timekeeper.xtime into xtime_sec" replaced a call to clocksource_cyc2ns() from timekeeping_get_ns() with an open-coded version of the same logic to avoid keeping a semi-redundant struct timespec in struct timekeeper. However, the commit also introduced a subtle semantic chan