Re: [PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread chenjun (AM)
在 2021/4/12 23:58, Richard Cochran 写道: > On Mon, Apr 12, 2021 at 02:52:11PM +, chenjun (AM) wrote: >> 在 2021/4/12 22:20, Richard Cochran 写道: >>> On Mon, Apr 12, 2021 at 12:45:51PM +, Chen Jun wrote: the correct error is covered by put_old_timex32. >>> >>> Well, the non-negative return

Re: [PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread Richard Cochran
On Mon, Apr 12, 2021 at 02:52:11PM +, chenjun (AM) wrote: > 在 2021/4/12 22:20, Richard Cochran 写道: > > On Mon, Apr 12, 2021 at 12:45:51PM +, Chen Jun wrote: > >> the correct error is covered by put_old_timex32. > > > > Well, the non-negative return code (TIME_OK, TIME_INS, etc) is > > clob

Re: [PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread chenjun (AM)
在 2021/4/12 22:20, Richard Cochran 写道: > On Mon, Apr 12, 2021 at 12:45:51PM +, Chen Jun wrote: >> the correct error is covered by put_old_timex32. > > Well, the non-negative return code (TIME_OK, TIME_INS, etc) is > clobbered by put_old_timex32(). > >> Fixes: f1f1d5ebd10f ("posix-timers: Intr

Re: [PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread Richard Cochran
On Mon, Apr 12, 2021 at 12:45:51PM +, Chen Jun wrote: > the correct error is covered by put_old_timex32. Well, the non-negative return code (TIME_OK, TIME_INS, etc) is clobbered by put_old_timex32(). > Fixes: f1f1d5ebd10f ("posix-timers: Introduce a syscall for clock tuning.") This is not th

[PATCH] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-12 Thread Chen Jun
the correct error is covered by put_old_timex32. Fixes: f1f1d5ebd10f ("posix-timers: Introduce a syscall for clock tuning.") Signed-off-by: Chen Jun --- kernel/time/posix-timers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/posix-timers.c b/kernel/time/pos