Re: [PATCH] time: add an offline-cpu check in add_timer_on()

2007-12-14 Thread Thomas Gleixner
On Fri, 14 Dec 2007, Andi Kleen wrote: > Miao Xie <[EMAIL PROTECTED]> writes: > > > Hi everyone, > > I think we need a check in the function add_timer_on() to avoid adding a > > timer into the timer list of an offline cpu. > > > > This patch fixes this problem in add_timer_on(). > > No it does

Re: [PATCH] time: add an offline-cpu check in add_timer_on()

2007-12-14 Thread Thomas Gleixner
On Fri, 14 Dec 2007, Miao Xie wrote: > Hi everyone, > I think we need a check in the function add_timer_on() to avoid adding a > timer into the timer list of an offline cpu. > > This patch fixes this problem in add_timer_on(). No, the patch is not fixing the problem. It crashes the machine. W

Re: [PATCH] time: add an offline-cpu check in add_timer_on()

2007-12-14 Thread Andi Kleen
Miao Xie <[EMAIL PROTECTED]> writes: > Hi everyone, > I think we need a check in the function add_timer_on() to avoid adding a > timer into the timer list of an offline cpu. > > This patch fixes this problem in add_timer_on(). No it doesn't -- it will just crash if a caller does that. If it's a

[PATCH] time: add an offline-cpu check in add_timer_on()

2007-12-14 Thread Miao Xie
Hi everyone, I think we need a check in the function add_timer_on() to avoid adding a timer into the timer list of an offline cpu. This patch fixes this problem in add_timer_on(). Signed-off-by: Miao Xie <[EMAIL PROTECTED]> --- kernel/timer.c |1 + 1 files changed, 1 insertions(+), 0 del