Re: [PATCH] timer: Fix possible issues with non serialized timer_pending( )

2013-04-03 Thread Christian Ruppert
Hello Vineet, In the following a patch for a seemingly unrelated problem (RB-trees in hrtimer implementation) which seems to fix the original problem at the same time. For the moment, this patch is insufficiently tested but I am posting it here (preliminarily) since it seems to be in line with Tho

Re: [PATCH] timer: Fix possible issues with non serialized timer_pending( )

2013-04-03 Thread Thomas Gleixner
Vineet, On Fri, 29 Mar 2013, Vineet Gupta wrote: > When stress testing ARC Linux from 3.9-rc3, we've hit a serialization > issue when mod_timer() races with itself. This is on a FPGA board and > kernel .config among others has !SMP and !PREEMPT_COUNT. > > The issue happens in mod_timer( ) becaus

Re: [PATCH] timer: Fix possible issues with non serialized timer_pending( )

2013-04-03 Thread Christian Ruppert
We have tested the patch in several configurations and boards using tests which previously crashed the kernel in less than an hour. The crashes in question could not be reproduced in long term tests (3 days) and nightly tests with the patch. I can thus confirm that this fixes a real issue. On Fri,

Re: [PATCH] timer: Fix possible issues with non serialized timer_pending( )

2013-04-03 Thread Vineet Gupta
Hi Thomas, Did you get a chance to look at this one ! It fixes a real problem for ARC platform - w/o it my stress test setup buckles up in ~20 mins. Thx, -Vineet On 03/29/2013 04:03 PM, Vineet Gupta wrote: > When stress testing ARC Linux from 3.9-rc3, we've hit a serialization > issue when mod_

[PATCH] timer: Fix possible issues with non serialized timer_pending( )

2013-03-29 Thread Vineet Gupta
When stress testing ARC Linux from 3.9-rc3, we've hit a serialization issue when mod_timer() races with itself. This is on a FPGA board and kernel .config among others has !SMP and !PREEMPT_COUNT. The issue happens in mod_timer( ) because timer_pending( ) based early exit check is NOT done inside