Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-08-26 Thread Rafael J. Wysocki
On Mon, Aug 26, 2019 at 10:02 AM Artem Bityutskiy wrote: > > On Mon, 2019-08-26 at 09:55 +0200, Rafael J. Wysocki wrote: > > Technically, Len Brown is the turbostat maintainer and I have been > > waiting for him to review the patch at least. Let me talk to Len. > > > > Hi Rafael, > > > I also sen

Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-08-26 Thread Rafael J. Wysocki
On Mon, Aug 26, 2019 at 6:25 AM Gustavo A. R. Silva wrote: > > Hi Rafael, > > On 4/23/19 3:23 AM, Rafael J. Wysocki wrote: > > On Mon, Apr 22, 2019 at 5:55 PM Gustavo A. R. Silva > > wrote: > >> > >> Hi all, > >> > >> Friendly ping: > >> > >> Who can take this? > > > > I've been waiting for Len t

Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-08-25 Thread Gustavo A. R. Silva
Hi Rafael, On 4/23/19 3:23 AM, Rafael J. Wysocki wrote: > On Mon, Apr 22, 2019 at 5:55 PM Gustavo A. R. Silva > wrote: >> >> Hi all, >> >> Friendly ping: >> >> Who can take this? > > I've been waiting for Len to comment on this, let me talk to him offlist. > I just noticed this hasn't been app

Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-04-23 Thread Rafael J. Wysocki
On Mon, Apr 22, 2019 at 5:55 PM Gustavo A. R. Silva wrote: > > Hi all, > > Friendly ping: > > Who can take this? I've been waiting for Len to comment on this, let me talk to him offlist. Thanks!

Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-04-22 Thread Gustavo A. R. Silva
Hi all, Friendly ping: Who can take this? Thanks -- Gustavo On 4/8/19 12:04 PM, Prarit Bhargava wrote: > > > On 4/8/19 12:12 PM, Gustavo A. R. Silva wrote: >> Fix file descriptor leaks by closing fp before return. >> >> Addresses-Coverity-ID: 1444591 ("Resource leak") >> Addresses-Coverity-ID

Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-04-08 Thread Prarit Bhargava
On 4/8/19 12:12 PM, Gustavo A. R. Silva wrote: > Fix file descriptor leaks by closing fp before return. > > Addresses-Coverity-ID: 1444591 ("Resource leak") > Addresses-Coverity-ID: 1444592 ("Resource leak") > Fixes: 5ea7647b333f ("tools/power turbostat: Warn on bad ACPI LPIT data") > Signed-of

[PATCH] tools/power turbostat: fix file descriptor leaks

2019-04-08 Thread Gustavo A. R. Silva
Fix file descriptor leaks by closing fp before return. Addresses-Coverity-ID: 1444591 ("Resource leak") Addresses-Coverity-ID: 1444592 ("Resource leak") Fixes: 5ea7647b333f ("tools/power turbostat: Warn on bad ACPI LPIT data") Signed-off-by: Gustavo A. R. Silva --- tools/power/x86/turbostat/turb