Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-07-17 Thread David R. Bild
On Wed, Jul 4, 2018 at 2:54 AM, Louis Collard wrote: > On Fri, Jun 29, 2018 at 9:03 PM, David R. Bild wrote: >> As a point of clarification (and correct me if I'm wrong), the TPM is >> always ready used to seed the rng. It just doesn't update the entropy >> pool estimate. > > Good point. > >> >>

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-07-03 Thread Louis Collard
On Fri, Jun 29, 2018 at 9:03 PM, David R. Bild wrote: > On Wed, Jun 27, 2018 at 1:11 AM, Louis Collard > wrote: >> >> On some systems we have seen large delays in boot time, due to >> blocking on a call to getrandom() before the entropy pool has been >> initialized. On these systems the usual sou

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-06-29 Thread David R. Bild
On Wed, Jun 27, 2018 at 1:11 AM, Louis Collard wrote: > > On some systems we have seen large delays in boot time, due to > blocking on a call to getrandom() before the entropy pool has been > initialized. On these systems the usual sources of entropy are not > sufficient to initialize the pool in

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-06-26 Thread Louis Collard
Thanks for all the replies, let me add some background around the motivation for this change. On some systems we have seen large delays in boot time, due to blocking on a call to getrandom() before the entropy pool has been initialized. On these systems the usual sources of entropy are not suffici

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-06-21 Thread Jarkko Sakkinen
On Mon, Jun 18, 2018 at 01:33:06PM -0600, Jason Gunthorpe wrote: > > > +module_param(override_rng_quality, short, 0644); > > > > Should this be 600 i.e. not to leak this information? > > There is a real push these days against adding module parameters, and > apparently, IMA can't function with TP

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-06-18 Thread Jason Gunthorpe
On Mon, Jun 18, 2018 at 09:07:12PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 02:54:38PM +0800, Louis Collard wrote: > > It is now possible for drivers to easily specify a hwrng quality, however > > most do not currently do this, and in cases where they do, it may be > > desirable to o

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-06-18 Thread Jarkko Sakkinen
On Fri, Jun 08, 2018 at 02:54:38PM +0800, Louis Collard wrote: > It is now possible for drivers to easily specify a hwrng quality, however > most do not currently do this, and in cases where they do, it may be > desirable to override the driver-specified value with a user-specified > one. This patc

[PATCH] tpm: Add module parameter for hwrng quality.

2018-06-07 Thread Louis Collard
It is now possible for drivers to easily specify a hwrng quality, however most do not currently do this, and in cases where they do, it may be desirable to override the driver-specified value with a user-specified one. This patch adds a parameter to set or override the hwrng quality. Signed-off-by