Re: [PATCH] tpm: Fix IRQ unwind ordering in TIS

2016-04-28 Thread Jarkko Sakkinen
On Thu, 2016-04-28 at 11:09 +0300, Jarkko Sakkinen wrote: > On Wed, 2016-04-27 at 10:58 -0600, Jason Gunthorpe wrote: > > > > The devm for the IRQ was placed on the chip, not the pdev. This can > > cause the irq to be still callable after the pdev has been cleaned up > > (eg priv kfree'd). > >   >

Re: [PATCH] tpm: Fix IRQ unwind ordering in TIS

2016-04-28 Thread Jarkko Sakkinen
On Wed, 2016-04-27 at 10:58 -0600, Jason Gunthorpe wrote: > The devm for the IRQ was placed on the chip, not the pdev. This can > cause the irq to be still callable after the pdev has been cleaned up > (eg priv kfree'd). >  > Found by CONFIG_DEBUG_SHIRQ=y >  > Reported-by: Stefan Berger > Fixes: 2

[PATCH] tpm: Fix IRQ unwind ordering in TIS

2016-04-27 Thread Jason Gunthorpe
The devm for the IRQ was placed on the chip, not the pdev. This can cause the irq to be still callable after the pdev has been cleaned up (eg priv kfree'd). Found by CONFIG_DEBUG_SHIRQ=y Reported-by: Stefan Berger Fixes: 233a065e0cd0 ("tpm: Get rid of chip->pdev") Signed-off-by: Jason Gunthorpe