Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Fri, Jul 12, 2019 at 05:27:34PM +0200, Greg KH wrote: > On Fri, Jul 12, 2019 at 08:00:12AM -0700, Doug Anderson wrote: > > Hi, > > > > On Fri, Jul 12, 2019 at 4:50 AM Greg KH wrote: > > > > > > On Thu, Jul 11, 2019 at 10:28:01AM -0700, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Thu, J

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Fri, 2019-07-12 at 08:00 -0700, Doug Anderson wrote: > * On 5.2 / 5.1: you've already got this picked to stable. Good > > * On 4.14 / 4.19: Jarkko will look at in 2 weeks. > > * On 4.9 and older: I'd propose skipping unless someone is known to > need a solution here. I'll prioritize 4.14 and

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Fri, Jul 12, 2019 at 08:00:12AM -0700, Doug Anderson wrote: > Hi, > > On Fri, Jul 12, 2019 at 4:50 AM Greg KH wrote: > > > > On Thu, Jul 11, 2019 at 10:28:01AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Jul 11, 2019 at 10:26 AM Greg KH > > > wrote: > > > > > > > > On Thu, Jul

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Fri, 2019-07-12 at 13:50 +0200, Greg KH wrote: > But the sysfs comment means I should not apply this backport then? > > Totally confused by this long thread, sorry. > > What am I supposed to do for the stable trees here? I'll work out a proper patch set for stable kernels with necessary patch

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

Hi, On Fri, Jul 12, 2019 at 4:50 AM Greg KH wrote: > > On Thu, Jul 11, 2019 at 10:28:01AM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Jul 11, 2019 at 10:26 AM Greg KH wrote: > > > > > > On Thu, Jul 11, 2019 at 02:17:26PM -0300, Jason Gunthorpe wrote: > > > > On Thu, Jul 11, 2019 at 07:04

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Fri, Jul 12, 2019 at 06:35:56AM +0300, Jarkko Sakkinen wrote: > On Fri, Jul 12, 2019 at 06:31:38AM +0300, Jarkko Sakkinen wrote: > > On Thu, Jul 11, 2019 at 04:46:26PM -0300, Jason Gunthorpe wrote: > > > On Thu, Jul 11, 2019 at 10:43:13PM +0300, Jarkko Sakkinen wrote: > > > > On Thu, Jul 11, 201

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 10:28:01AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Jul 11, 2019 at 10:26 AM Greg KH wrote: > > > > On Thu, Jul 11, 2019 at 02:17:26PM -0300, Jason Gunthorpe wrote: > > > On Thu, Jul 11, 2019 at 07:04:37PM +0200, Greg KH wrote: > > > > On Thu, Jul 11, 2019 at 01:39:15

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Fri, Jul 12, 2019 at 06:31:38AM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 11, 2019 at 04:46:26PM -0300, Jason Gunthorpe wrote: > > On Thu, Jul 11, 2019 at 10:43:13PM +0300, Jarkko Sakkinen wrote: > > > On Thu, Jul 11, 2019 at 09:35:33PM +0300, Jarkko Sakkinen wrote: > > > > > Careful with this

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 04:46:26PM -0300, Jason Gunthorpe wrote: > On Thu, Jul 11, 2019 at 10:43:13PM +0300, Jarkko Sakkinen wrote: > > On Thu, Jul 11, 2019 at 09:35:33PM +0300, Jarkko Sakkinen wrote: > > > > Careful with this, you can't backport this to any kernels that don't > > > > have the sysf

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

Hi, On Thu, Jul 11, 2019 at 12:43 PM Jarkko Sakkinen wrote: > > On Thu, Jul 11, 2019 at 09:35:33PM +0300, Jarkko Sakkinen wrote: > > > Careful with this, you can't backport this to any kernels that don't > > > have the sysfs ops locking changes or they will crash in sysfs code. > > > > Oops, I wa

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 10:43:13PM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 11, 2019 at 09:35:33PM +0300, Jarkko Sakkinen wrote: > > > Careful with this, you can't backport this to any kernels that don't > > > have the sysfs ops locking changes or they will crash in sysfs code. > > > > Oops, I

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 09:35:33PM +0300, Jarkko Sakkinen wrote: > > Careful with this, you can't backport this to any kernels that don't > > have the sysfs ops locking changes or they will crash in sysfs code. > > Oops, I was way too fast! Thanks Jason. Hmm... hold on a second. How would the cr

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 01:39:15PM -0300, Jason Gunthorpe wrote: > On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > > From: Vadim Sukhomlinov > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip an

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > From: Vadim Sukhomlinov > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > future TPM operations. TPM 1.2 behavior was different, future T

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

Hi, On Thu, Jul 11, 2019 at 10:26 AM Greg KH wrote: > > On Thu, Jul 11, 2019 at 02:17:26PM -0300, Jason Gunthorpe wrote: > > On Thu, Jul 11, 2019 at 07:04:37PM +0200, Greg KH wrote: > > > On Thu, Jul 11, 2019 at 01:39:15PM -0300, Jason Gunthorpe wrote: > > > > On Thu, Jul 11, 2019 at 09:29:19AM -

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 02:17:26PM -0300, Jason Gunthorpe wrote: > On Thu, Jul 11, 2019 at 07:04:37PM +0200, Greg KH wrote: > > On Thu, Jul 11, 2019 at 01:39:15PM -0300, Jason Gunthorpe wrote: > > > On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > > > > From: Vadim Sukhomlinov >

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 07:04:37PM +0200, Greg KH wrote: > On Thu, Jul 11, 2019 at 01:39:15PM -0300, Jason Gunthorpe wrote: > > On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > > > From: Vadim Sukhomlinov > > > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. > >

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 01:39:15PM -0300, Jason Gunthorpe wrote: > On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > > From: Vadim Sukhomlinov > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip an

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

Hi, On Thu, Jul 11, 2019 at 9:39 AM Jason Gunthorpe wrote: > > On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > > From: Vadim Sukhomlinov > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and di

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jul 11, 2019 at 09:29:19AM -0700, Douglas Anderson wrote: > From: Vadim Sukhomlinov > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > future TPM operations. TPM 1.2 behavior was different, future T

[PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

From: Vadim Sukhomlinov commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream. TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that f

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Thu, Jun 13, 2019 at 08:20:41AM -0700, Doug Anderson wrote: > Found the patch in your tree at > . > I'm decidedly a non-expert here, mostly just wrangling a patch that > someone else came up with.

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

Hi, On Thu, Jun 13, 2019 at 6:59 AM Jarkko Sakkinen wrote: > > On Wed, Jun 12, 2019 at 10:16:18PM +0300, Jarkko Sakkinen wrote: > > On Mon, Jun 10, 2019 at 03:01:18PM -0700, Douglas Anderson wrote: > > > From: Vadim Sukhomlinov > > > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM ch

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Wed, Jun 12, 2019 at 10:16:18PM +0300, Jarkko Sakkinen wrote: > On Mon, Jun 10, 2019 at 03:01:18PM -0700, Douglas Anderson wrote: > > From: Vadim Sukhomlinov > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > > future TPM operations. TPM 1.2 behavior was differe

Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

On Mon, Jun 10, 2019 at 03:01:18PM -0700, Douglas Anderson wrote: > From: Vadim Sukhomlinov > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > future TPM operations. TPM 1.2 behavior was different, future TPM > operations weren't disabled, causing rare issues. This pat

[PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

From: Vadim Sukhomlinov TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that future TPM operations are disabled. Signed-off-by: Vadim Su