Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-13 Thread Jarkko Sakkinen
On Wed, Mar 13, 2019 at 03:22:32PM +0200, Jarkko Sakkinen wrote: > On Tue, Mar 12, 2019 at 01:04:58PM -0400, Mimi Zohar wrote: > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > We're having lots of problems with TPM commands timing out, and we're > > > seeing these problems across lo

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-13 Thread Jarkko Sakkinen
On Tue, Mar 12, 2019 at 01:04:58PM -0400, Mimi Zohar wrote: > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > We're having lots of problems with TPM commands timing out, and we're > > seeing these problems across lots of different hardware (both v1/v2). > > > > I instrumented the driver

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Mimi Zohar
On Tue, 2019-03-12 at 20:08 +, Calvin Owens wrote: > On Tuesday 03/12 at 13:04 -0400, Mimi Zohar wrote: > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > We're having lots of problems with TPM commands timing out, and we're > > > seeing these problems across lots of different har

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Calvin Owens
On Tuesday 03/12 at 13:04 -0400, Mimi Zohar wrote: > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > We're having lots of problems with TPM commands timing out, and we're > > seeing these problems across lots of different hardware (both v1/v2). > > > > I instrumented the driver to colle

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Calvin Owens
On Tuesday 03/12 at 17:39 +0200, Jarkko Sakkinen wrote: > On Tue, Mar 12, 2019 at 07:42:46AM -0700, James Bottomley wrote: > > On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > > > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > > > On Mon, 2019-03-11 at 16:54 -0700,

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Calvin Owens
On Monday 03/11 at 17:27 -0700, James Bottomley wrote: > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > e're having lots of problems with TPM commands timing out, and we're > > seeing these problems across lots of different hardware (both v1/v2). > > > > I instrumented the driver to co

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Mimi Zohar
On Tue, 2019-03-12 at 10:14 -0700, James Bottomley wrote: > > > However, I am saying we should root cause this problem rather than > > > take a blind shot at the apparent timeout complexity. My timeout > > > instability is definitely related to the polling adjustments, so > > > it's not unreasona

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread James Bottomley
On Tue, 2019-03-12 at 12:59 -0400, Mimi Zohar wrote: > On Tue, 2019-03-12 at 07:42 -0700, James Bottomley wrote: > > On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > > > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owe

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Mimi Zohar
On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > We're having lots of problems with TPM commands timing out, and we're > seeing these problems across lots of different hardware (both v1/v2). > > I instrumented the driver to collect latency data, but I wasn't able to > find any specific tim

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Mimi Zohar
On Tue, 2019-03-12 at 07:42 -0700, James Bottomley wrote: > On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > > e're having lots of problems with TPM comma

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Mimi Zohar
On Tue, 2019-03-12 at 14:36 +0200, Jarkko Sakkinen wrote: > On Mon, Mar 11, 2019 at 04:54:04PM -0700, Calvin Owens wrote: > > We're having lots of problems with TPM commands timing out, and we're > > seeing these problems across lots of different hardware (both v1/v2). > > > > I instrumented the d

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Jarkko Sakkinen
On Tue, Mar 12, 2019 at 07:42:46AM -0700, James Bottomley wrote: > On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > > e're having lots of problems with TP

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Jarkko Sakkinen
On Mon, Mar 11, 2019 at 04:54:04PM -0700, Calvin Owens wrote: > We're having lots of problems with TPM commands timing out, and we're > seeing these problems across lots of different hardware (both v1/v2). > > I instrumented the driver to collect latency data, but I wasn't able to > find any speci

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread James Bottomley
On Tue, 2019-03-12 at 14:50 +0200, Jarkko Sakkinen wrote: > On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > > e're having lots of problems with TPM commands timing out, and > > > we're seeing these problems across lots

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Jarkko Sakkinen
On Mon, Mar 11, 2019 at 05:27:43PM -0700, James Bottomley wrote: > On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > > e're having lots of problems with TPM commands timing out, and we're > > seeing these problems across lots of different hardware (both v1/v2). > > > > I instrumented the dr

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-12 Thread Jarkko Sakkinen
On Mon, Mar 11, 2019 at 04:54:04PM -0700, Calvin Owens wrote: > We're having lots of problems with TPM commands timing out, and we're > seeing these problems across lots of different hardware (both v1/v2). > > I instrumented the driver to collect latency data, but I wasn't able to > find any speci

Re: [PATCH] tpm: Make timeout logic simpler and more robust

2019-03-11 Thread James Bottomley
On Mon, 2019-03-11 at 16:54 -0700, Calvin Owens wrote: > e're having lots of problems with TPM commands timing out, and we're > seeing these problems across lots of different hardware (both v1/v2). > > I instrumented the driver to collect latency data, but I wasn't able > to find any specific time

[PATCH] tpm: Make timeout logic simpler and more robust

2019-03-11 Thread Calvin Owens
We're having lots of problems with TPM commands timing out, and we're seeing these problems across lots of different hardware (both v1/v2). I instrumented the driver to collect latency data, but I wasn't able to find any specific timeout to fix: it seems like many of them are too aggressive. So I