Re: [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-11-03 Thread Kenneth R. Crudup
On Wed, 28 Oct 2020, Tyler Hicks wrote: > Hi Kai, Kenneth, and Mimi - could one or two of you please follow these > steps: ... OK, I built a kernel with the two patches applied, and with and without commit 7f3d176f5f7e, and when I run "sudo fwupdtpmevlog" (which normally causes a panic() when 7

Re: [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-10-30 Thread Kai-Heng Feng
> On Oct 29, 2020, at 01:39, Tyler Hicks wrote: > > On 2020-10-28 11:30:11, Tyler Hicks wrote: >> So, we need help from Kai, Kenneth, or Mimi to verify my assumption that >> their firmware is providing an empty main event log and a populated >> final event log. > > Hi Kai, Kenneth, and Mimi -

Re: [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-10-29 Thread Jarkko Sakkinen
On Wed, Oct 28, 2020 at 10:41:02AM -0500, Tyler Hicks wrote: > Mimic the pre-existing ACPI and Device Tree event log behavior by not > creating the binary_bios_measurements file when the EFI TPM event log is > empty. > > This fixes the following NULL pointer dereference that can occur when > readi

[PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-10-28 Thread Tyler Hicks
Mimic the pre-existing ACPI and Device Tree event log behavior by not creating the binary_bios_measurements file when the EFI TPM event log is empty. This fixes the following NULL pointer dereference that can occur when reading /sys/kernel/security/tpm0/binary_bios_measurements after the kernel re

Re: [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-10-28 Thread Tyler Hicks
On 2020-10-28 10:41:02, Tyler Hicks wrote: > Mimic the pre-existing ACPI and Device Tree event log behavior by not > creating the binary_bios_measurements file when the EFI TPM event log is > empty. > > This fixes the following NULL pointer dereference that can occur when > reading /sys/kernel/sec

Re: [PATCH] tpm: efi: Don't create binary_bios_measurements file for an empty log

2020-10-28 Thread Tyler Hicks
On 2020-10-28 11:30:11, Tyler Hicks wrote: > So, we need help from Kai, Kenneth, or Mimi to verify my assumption that > their firmware is providing an empty main event log and a populated > final event log. Hi Kai, Kenneth, and Mimi - could one or two of you please follow these steps: 1) Apply th