Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-11 Thread James Morris
On Tue, 4 Sep 2012, Kent Yoder wrote: > acpi_os_map_memory expects its return value to be in the __iomem address > space. Tag the variable we're using as such and use memcpy_fromio to > avoid further sparse warnings. > > Signed-off-by: Kent Yoder Applied to

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-11 Thread James Morris
On Tue, 4 Sep 2012, Kent Yoder wrote: acpi_os_map_memory expects its return value to be in the __iomem address space. Tag the variable we're using as such and use memcpy_fromio to avoid further sparse warnings. Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com Applied to

[PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-04 Thread Kent Yoder
acpi_os_map_memory expects its return value to be in the __iomem address space. Tag the variable we're using as such and use memcpy_fromio to avoid further sparse warnings. Signed-off-by: Kent Yoder --- drivers/char/tpm/tpm_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-04 Thread Kent Yoder
On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote: > Sparse finds that bug as well. ;) > > drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment > (different address spaces) > drivers/acpi/acpica/tbfadt.c:247:15:expected struct acpi_table_header > *table >

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-04 Thread Kent Yoder
On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote: Sparse finds that bug as well. ;) drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment (different address spaces) drivers/acpi/acpica/tbfadt.c:247:15:expected struct acpi_table_header *table

[PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-04 Thread Kent Yoder
acpi_os_map_memory expects its return value to be in the __iomem address space. Tag the variable we're using as such and use memcpy_fromio to avoid further sparse warnings. Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com --- drivers/char/tpm/tpm_acpi.c | 4 ++-- 1 file changed, 2

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-02 Thread Dan Carpenter
On Thu, Aug 30, 2012 at 02:21:55PM -0500, Kent Yoder wrote: > On Thu, Aug 30, 2012 at 10:45:56AM -0700, Dan Carpenter wrote: > > On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: > > > acpi_os_map_memory expects its return value to be in the __iomem address > > > space. Cast it back

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-09-02 Thread Dan Carpenter
On Thu, Aug 30, 2012 at 02:21:55PM -0500, Kent Yoder wrote: On Thu, Aug 30, 2012 at 10:45:56AM -0700, Dan Carpenter wrote: On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: acpi_os_map_memory expects its return value to be in the __iomem address space. Cast it back later when

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-08-30 Thread Kent Yoder
On Thu, Aug 30, 2012 at 10:45:56AM -0700, Dan Carpenter wrote: > On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: > > acpi_os_map_memory expects its return value to be in the __iomem address > > space. Cast it back later when used in a memcpy to avoid the same sparse > > warning there.

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-08-30 Thread Dan Carpenter
On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: > acpi_os_map_memory expects its return value to be in the __iomem address > space. Cast it back later when used in a memcpy to avoid the same sparse > warning there. > > Signed-off-by: Kent Yoder I can't download linux-next right now

[PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-08-30 Thread Kent Yoder
acpi_os_map_memory expects its return value to be in the __iomem address space. Cast it back later when used in a memcpy to avoid the same sparse warning there. Signed-off-by: Kent Yoder --- drivers/char/tpm/tpm_acpi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-08-30 Thread Kent Yoder
acpi_os_map_memory expects its return value to be in the __iomem address space. Cast it back later when used in a memcpy to avoid the same sparse warning there. Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com --- drivers/char/tpm/tpm_acpi.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-08-30 Thread Dan Carpenter
On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: acpi_os_map_memory expects its return value to be in the __iomem address space. Cast it back later when used in a memcpy to avoid the same sparse warning there. Signed-off-by: Kent Yoder k...@linux.vnet.ibm.com I can't download

Re: [PATCH] tpm: fix tpm_acpi sparse warning on different address spaces

2012-08-30 Thread Kent Yoder
On Thu, Aug 30, 2012 at 10:45:56AM -0700, Dan Carpenter wrote: On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: acpi_os_map_memory expects its return value to be in the __iomem address space. Cast it back later when used in a memcpy to avoid the same sparse warning there.