RE: [PATCH] tpm: tpm_try_transmit() ignore value of go_to_idle()

2018-10-17 Thread Winkler, Tomas
.@vger.kernel.org; linux-security- > mod...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] tpm: tpm_try_transmit() ignore value of go_to_idle() > > On Mon, 15 Oct 2018, Tomas Winkler wrote: > > Ignore the return value of go_to_idle() in tpm_try_transmit().

Re: [PATCH] tpm: tpm_try_transmit() ignore value of go_to_idle()

2018-10-17 Thread Jarkko Sakkinen
On Mon, 15 Oct 2018, Tomas Winkler wrote: Ignore the return value of go_to_idle() in tpm_try_transmit(). Once it may shadow the return value of actual tpm operation, second the consequent command will fail as well and the error will be caought anyway. Last fix wrong goto, that jumped back instead

RE: [PATCH] tpm: tpm_try_transmit() ignore value of go_to_idle()

2018-10-15 Thread Winkler, Tomas
> > On Mon, Oct 15, 2018 at 02:14:34PM +0300, Tomas Winkler wrote: > > Ignore the return value of go_to_idle() in tpm_try_transmit(). > > Once it may shadow the return value of actual tpm operation, second > > the consequent command will fail as well and the error will be caought > > anyway. >

Re: [PATCH] tpm: tpm_try_transmit() ignore value of go_to_idle()

2018-10-15 Thread Jason Gunthorpe
On Mon, Oct 15, 2018 at 02:14:34PM +0300, Tomas Winkler wrote: > Ignore the return value of go_to_idle() in tpm_try_transmit(). > Once it may shadow the return value of actual tpm operation, > second the consequent command will fail as well and the error > will be caought anyway. > Last fix wrong g

[PATCH] tpm: tpm_try_transmit() ignore value of go_to_idle()

2018-10-15 Thread Tomas Winkler
Ignore the return value of go_to_idle() in tpm_try_transmit(). Once it may shadow the return value of actual tpm operation, second the consequent command will fail as well and the error will be caought anyway. Last fix wrong goto, that jumped back instead of forward. Fixes: 627448e85c76 ("tpm: sep