Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-09 Thread Jarkko Sakkinen
On Wed, 2015-04-08 at 10:28 -0600, Jason Gunthorpe wrote: > On Wed, Apr 08, 2015 at 10:26:07AM +0300, Jarkko Sakkinen wrote: > > On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: > > > On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: > > > > Added PPI interface to

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-09 Thread Jarkko Sakkinen
On Wed, 2015-04-08 at 10:28 -0600, Jason Gunthorpe wrote: On Wed, Apr 08, 2015 at 10:26:07AM +0300, Jarkko Sakkinen wrote: On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: Added PPI interface to the

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-08 Thread Jason Gunthorpe
On Wed, Apr 08, 2015 at 10:26:07AM +0300, Jarkko Sakkinen wrote: > On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: > > On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: > > > Added PPI interface to the character device. PPI interface is also kept > > > in the pdev

Re: [tpmdd-devel] [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-08 Thread Jarkko Sakkinen
Gave this some rethought :) On Wed, Apr 08, 2015 at 10:26:07AM +0300, Jarkko Sakkinen wrote: > On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: > > On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: > > > Added PPI interface to the character device. PPI interface is

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-08 Thread Jarkko Sakkinen
On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: > On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: > > Added PPI interface to the character device. PPI interface is also kept > > in the pdev for backwards compatibility. > > Could you look at just completely moving

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-08 Thread Jarkko Sakkinen
On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: Added PPI interface to the character device. PPI interface is also kept in the pdev for backwards compatibility. Could you look at just completely moving the

Re: [tpmdd-devel] [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-08 Thread Jarkko Sakkinen
Gave this some rethought :) On Wed, Apr 08, 2015 at 10:26:07AM +0300, Jarkko Sakkinen wrote: On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: Added PPI interface to the character device. PPI interface is also

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-08 Thread Jason Gunthorpe
On Wed, Apr 08, 2015 at 10:26:07AM +0300, Jarkko Sakkinen wrote: On Wed, Apr 01, 2015 at 12:19:25PM -0600, Jason Gunthorpe wrote: On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: Added PPI interface to the character device. PPI interface is also kept in the pdev for

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-01 Thread Jason Gunthorpe
On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: > Added PPI interface to the character device. PPI interface is also kept > in the pdev for backwards compatibility. Could you look at just completely moving the PPI interface to the char dev and then adding a symlink from the pdev?

[PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-01 Thread Jarkko Sakkinen
Added PPI interface to the character device. PPI interface is also kept in the pdev for backwards compatibility. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 16 +++--- drivers/char/tpm/tpm-interface.c | 1 + drivers/char/tpm/tpm.h | 3 +-

[PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-01 Thread Jarkko Sakkinen
Added PPI interface to the character device. PPI interface is also kept in the pdev for backwards compatibility. Signed-off-by: Jarkko Sakkinen jarkko.sakki...@linux.intel.com --- drivers/char/tpm/tpm-chip.c | 16 +++--- drivers/char/tpm/tpm-interface.c | 1 + drivers/char/tpm/tpm.h

Re: [PATCH] tpm: unified PPI interface for TPM 1.x/2.0 devices

2015-04-01 Thread Jason Gunthorpe
On Wed, Apr 01, 2015 at 03:28:52PM +0300, Jarkko Sakkinen wrote: Added PPI interface to the character device. PPI interface is also kept in the pdev for backwards compatibility. Could you look at just completely moving the PPI interface to the char dev and then adding a symlink from the pdev?