Re: [tpmdd-devel] [PATCH] tpm: use tpm_pcr_read_dev() in tpm_do_selftest()

2014-09-13 Thread Jarkko Sakkinen
On Fri, Sep 12, 2014 at 09:59:05AM -0600, Jason Gunthorpe wrote: > On Fri, Sep 12, 2014 at 04:06:41PM +0300, Jarkko Sakkinen wrote: > > It does not make sense to construct the PCR read command in > > tpm_do_selftest() when there is already a function that does > > the job. > > This would seem to u

Re: [tpmdd-devel] [PATCH] tpm: use tpm_pcr_read_dev() in tpm_do_selftest()

2014-09-12 Thread Jason Gunthorpe
On Fri, Sep 12, 2014 at 04:06:41PM +0300, Jarkko Sakkinen wrote: > It does not make sense to construct the PCR read command in > tpm_do_selftest() when there is already a function that does > the job. This would seem to undo an older patch, I don't think things have changed enough for that to make

[PATCH] tpm: use tpm_pcr_read_dev() in tpm_do_selftest()

2014-09-12 Thread Jarkko Sakkinen
It does not make sense to construct the PCR read command in tpm_do_selftest() when there is already a function that does the job. Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-interface.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/char/tpm/tp