Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-25 Thread Jason Gunthorpe
On Mon, Aug 25, 2014 at 06:38:33AM +, Scot Doyle wrote: >command. Now the chip is running. It will not be reboot on resume >(unlike stock SeaBIOS), presumably since the firmware is not >interacting with the TPM. But because an error 38 is returned during >the selftest issued on

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-24 Thread Scot Doyle
On Fri, 22 Aug 2014, Jason Gunthorpe wrote: > On Fri, Aug 22, 2014 at 08:17:27PM +, Scot Doyle wrote: >> On Fri, 22 Aug 2014, Jason Gunthorpe wrote: >>> On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote: Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-22 Thread Peter Hüwe
CC: Luigi, he works at Google and is responsible for the TPMs in Chromebooks ;) Thanks, Peter Am Freitag, 22. August 2014, 22:32:41 schrieb Jason Gunthorpe: > On Fri, Aug 22, 2014 at 08:17:27PM +, Scot Doyle wrote: > > On Fri, 22 Aug 2014, Jason Gunthorpe wrote: > > > On Fri, Aug 22, 2014 at

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-22 Thread Jason Gunthorpe
On Fri, Aug 22, 2014 at 08:17:27PM +, Scot Doyle wrote: > On Fri, 22 Aug 2014, Jason Gunthorpe wrote: > > On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote: > >> Some machines, such as the Acer C720 and Toshiba CB35, have TPMs > >> that do not use interrupts while also having an ACPI T

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-22 Thread Scot Doyle
On Fri, 22 Aug 2014, Jason Gunthorpe wrote: > On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote: >> Some machines, such as the Acer C720 and Toshiba CB35, have TPMs >> that do not use interrupts while also having an ACPI TPM entry > > How do these machines work in Windows? I don't know. S

Re: [PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-22 Thread Jason Gunthorpe
On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote: > Some machines, such as the Acer C720 and Toshiba CB35, have TPMs > that do not use interrupts while also having an ACPI TPM entry How do these machines work in Windows? Why only resume? Shouldn't every TPM command (such as the 3 or 4 t

[PATCH] tpm_tis: Verify ACPI-specified interrupt

2014-08-21 Thread Scot Doyle
Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do not use interrupts while also having an ACPI TPM entry indicating a specific interrupt to be used. Since this interrupt is invalid, these machines freeze on resume until the interrupt times out. Generate the ACPI-specified i