Re: [PATCH] trace: don't call page_to_pfn() if page is NULL

2012-09-20 Thread Mel Gorman
On Thu, Sep 20, 2012 at 09:48:24AM -0400, Steven Rostedt wrote: > Mel, > > As you were the original author of this code, can I get your Acked-by? > Sure. Problem as described is valid and the patch looks ok Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send t

Re: [PATCH] trace: don't call page_to_pfn() if page is NULL

2012-09-20 Thread Steven Rostedt
Mel, As you were the original author of this code, can I get your Acked-by? Thanks, -- Steve On Thu, 2012-09-20 at 14:04 +0800, Wen Congyang wrote: > When allocating memory fails, page is NULL. page_to_pfn() will > cause the kernel panicked if we don't use sparsemem vmemmap. > > Signed-off-by

Re: [PATCH] trace: don't call page_to_pfn() if page is NULL

2012-09-20 Thread Steven Rostedt
On Thu, 2012-09-20 at 15:28 +0900, Minchan Kim wrote: > On Thu, Sep 20, 2012 at 02:04:47PM +0800, Wen Congyang wrote: > > When allocating memory fails, page is NULL. page_to_pfn() will > > cause the kernel panicked if we don't use sparsemem vmemmap. > > > > Signed-off-by: Wen Congyang > > Nice c

Re: [PATCH] trace: don't call page_to_pfn() if page is NULL

2012-09-19 Thread Minchan Kim
On Thu, Sep 20, 2012 at 02:04:47PM +0800, Wen Congyang wrote: > When allocating memory fails, page is NULL. page_to_pfn() will > cause the kernel panicked if we don't use sparsemem vmemmap. > > Signed-off-by: Wen Congyang Nice catch. I think it's a candidate of stable. Reviewed-by: Minchan Kim

[PATCH] trace: don't call page_to_pfn() if page is NULL

2012-09-19 Thread Wen Congyang
When allocating memory fails, page is NULL. page_to_pfn() will cause the kernel panicked if we don't use sparsemem vmemmap. Signed-off-by: Wen Congyang --- include/trace/events/kmem.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/kmem.h b/inclu