Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Keun-O Park
On Thu, Mar 21, 2013 at 12:33 PM, Mathieu Desnoyers wrote: > * Keun-O Park (kpark3...@gmail.com) wrote: >> On Thu, Mar 21, 2013 at 11:45 AM, Mathieu Desnoyers >> wrote: >> > * Keun-O Park (kpark3...@gmail.com) wrote: >> >> On Thu, Mar 21, 2013 at 8:01 AM, Steven Rostedt >> >> wrote: >> >> > On

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Mathieu Desnoyers
* Keun-O Park (kpark3...@gmail.com) wrote: > On Thu, Mar 21, 2013 at 11:45 AM, Mathieu Desnoyers > wrote: > > * Keun-O Park (kpark3...@gmail.com) wrote: > >> On Thu, Mar 21, 2013 at 8:01 AM, Steven Rostedt > >> wrote: > >> > On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote: > >> >> * S

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Keun-O Park
On Thu, Mar 21, 2013 at 11:45 AM, Mathieu Desnoyers wrote: > * Keun-O Park (kpark3...@gmail.com) wrote: >> On Thu, Mar 21, 2013 at 8:01 AM, Steven Rostedt wrote: >> > On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote: >> >> * Steven Rostedt (rost...@goodmis.org) wrote: >> >> > On Wed, 20

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Mathieu Desnoyers
* Keun-O Park (kpark3...@gmail.com) wrote: > On Thu, Mar 21, 2013 at 8:01 AM, Steven Rostedt wrote: > > On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote: > >> * Steven Rostedt (rost...@goodmis.org) wrote: > >> > On Wed, 2013-03-20 at 12:18 +0900, kpark3...@gmail.com wrote: > >> > > From:

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Keun-O Park
On Thu, Mar 21, 2013 at 10:39 AM, Keun-O Park wrote: > On Thu, Mar 21, 2013 at 8:01 AM, Steven Rostedt wrote: >> On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote: >>> * Steven Rostedt (rost...@goodmis.org) wrote: >>> > On Wed, 2013-03-20 at 12:18 +0900, kpark3...@gmail.com wrote: >>> >

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Keun-O Park
On Thu, Mar 21, 2013 at 8:01 AM, Steven Rostedt wrote: > On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote: >> * Steven Rostedt (rost...@goodmis.org) wrote: >> > On Wed, 2013-03-20 at 12:18 +0900, kpark3...@gmail.com wrote: >> > > From: Sahara >> > > >> > > Somehow tracepoint_entry_add/r

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Steven Rostedt
On Wed, 2013-03-20 at 14:01 -0400, Mathieu Desnoyers wrote: > * Steven Rostedt (rost...@goodmis.org) wrote: > > On Wed, 2013-03-20 at 12:18 +0900, kpark3...@gmail.com wrote: > > > From: Sahara > > > > > > Somehow tracepoint_entry_add/remove_probe functions allow a null probe > > > function. > >

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Mathieu Desnoyers
* Steven Rostedt (rost...@goodmis.org) wrote: > On Wed, 2013-03-20 at 12:18 +0900, kpark3...@gmail.com wrote: > > From: Sahara > > > > Somehow tracepoint_entry_add/remove_probe functions allow a null probe > > function. > > You actually hit this in practice, or is this just something that you >

Re: [PATCH] tracepoints: prevents null probe from being added

2013-03-20 Thread Steven Rostedt
On Wed, 2013-03-20 at 12:18 +0900, kpark3...@gmail.com wrote: > From: Sahara > > Somehow tracepoint_entry_add/remove_probe functions allow a null probe > function. You actually hit this in practice, or is this just something that you observe from code review? > Especially on getting a null pro

[PATCH] tracepoints: prevents null probe from being added

2013-03-19 Thread kpark3469
From: Sahara Somehow tracepoint_entry_add/remove_probe functions allow a null probe function. Especially on getting a null probe in remove function, it seems to be used to remove all probe functions in the entry. But, the code is not handled as expected. Since the tracepoint_entry maintains funcs