Re: [PATCH] tracing: Add *iter check for NULL

2016-06-19 Thread Namhyung Kim
On Fri, Jun 17, 2016 at 02:24:57PM -0400, Steven Rostedt wrote: > I tried your patch and it works until you remove the module and try > reading the trace again. As I said, you left out later processing. This > should not exit on error. Below is a patch I wrote, and it works well. > > I'll add you

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-19 Thread Namhyung Kim
On Fri, Jun 17, 2016 at 02:24:57PM -0400, Steven Rostedt wrote: > I tried your patch and it works until you remove the module and try > reading the trace again. As I said, you left out later processing. This > should not exit on error. Below is a patch I wrote, and it works well. > > I'll add you

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-17 Thread Steven Rostedt
On Fri, 17 Jun 2016 12:38:41 -0400 Steven Rostedt wrote: > On Wed, 1 Jun 2016 16:31:10 +0800 > zhengjun.x...@intel.com wrote: > > > From: xingzhen > > > > 3debb0a9ddb adding a "__used" to the variable in the > > __trace_printk_fmt section.

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-17 Thread Steven Rostedt
On Fri, 17 Jun 2016 12:38:41 -0400 Steven Rostedt wrote: > On Wed, 1 Jun 2016 16:31:10 +0800 > zhengjun.x...@intel.com wrote: > > > From: xingzhen > > > > 3debb0a9ddb adding a "__used" to the variable in the > > __trace_printk_fmt section. Sometimes it will cause > > *iter to be NULL, then

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-17 Thread Steven Rostedt
On Wed, 1 Jun 2016 16:31:10 +0800 zhengjun.x...@intel.com wrote: > From: xingzhen > > 3debb0a9ddb adding a "__used" to the variable in the > __trace_printk_fmt section. Sometimes it will cause > *iter to be NULL, then strcmp in lookup_format and > strcpy in

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-17 Thread Steven Rostedt
On Wed, 1 Jun 2016 16:31:10 +0800 zhengjun.x...@intel.com wrote: > From: xingzhen > > 3debb0a9ddb adding a "__used" to the variable in the > __trace_printk_fmt section. Sometimes it will cause > *iter to be NULL, then strcmp in lookup_format and > strcpy in hold_module_trace_bprintk_format

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-02 Thread Namhyung Kim
Hello, On Wed, Jun 1, 2016 at 5:31 PM, wrote: > From: xingzhen > > 3debb0a9ddb adding a "__used" to the variable in the > __trace_printk_fmt section. Sometimes it will cause > *iter to be NULL, then strcmp in lookup_format and > strcpy in

Re: [PATCH] tracing: Add *iter check for NULL

2016-06-02 Thread Namhyung Kim
Hello, On Wed, Jun 1, 2016 at 5:31 PM, wrote: > From: xingzhen > > 3debb0a9ddb adding a "__used" to the variable in the > __trace_printk_fmt section. Sometimes it will cause > *iter to be NULL, then strcmp in lookup_format and > strcpy in hold_module_trace_bprintk_format will panic. > >

[PATCH] tracing: Add *iter check for NULL

2016-06-01 Thread zhengjun . xing
From: xingzhen 3debb0a9ddb adding a "__used" to the variable in the __trace_printk_fmt section. Sometimes it will cause *iter to be NULL, then strcmp in lookup_format and strcpy in hold_module_trace_bprintk_format will panic. Signed-off-by: xingzhen

[PATCH] tracing: Add *iter check for NULL

2016-06-01 Thread zhengjun . xing
From: xingzhen 3debb0a9ddb adding a "__used" to the variable in the __trace_printk_fmt section. Sometimes it will cause *iter to be NULL, then strcmp in lookup_format and strcpy in hold_module_trace_bprintk_format will panic. Signed-off-by: xingzhen --- kernel/trace/trace_printk.c | 3 +++ 1