Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 12:28:32 -0500 Mathieu Desnoyers wrote: > > Again, it's not a requirement, it's just an enhancement. > > How does this have anything to do with dispensing from testing the > new behavior ? If the new behavior has a bug that causes it to > silently truncate the trace marker

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-10 11:38, Steven Rostedt wrote: On Sun, 10 Dec 2023 11:07:22 -0500 Mathieu Desnoyers wrote: It just allows more to be written in one go. I don't see why the tests need to cover this or detect this change. If the purpose of this change is to ensure that the entire trace marker

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 11:07:22 -0500 Mathieu Desnoyers wrote: > > It just allows more to be written in one go. > > > > I don't see why the tests need to cover this or detect this change. > > If the purpose of this change is to ensure that the entire > trace marker payload is shown within a

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-10 10:30, Steven Rostedt wrote: On Sun, 10 Dec 2023 09:09:06 -0500 Mathieu Desnoyers wrote: On 2023-12-09 17:50, Steven Rostedt wrote: From: "Steven Rostedt (Google)" Allow a trace write to be as big as the ring buffer tracing data will allow. Currently, it only allows writes of

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Steven Rostedt
On Sun, 10 Dec 2023 09:09:06 -0500 Mathieu Desnoyers wrote: > On 2023-12-09 17:50, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > Allow a trace write to be as big as the ring buffer tracing data will > > allow. Currently, it only allows writes of 1KB in size, but there's no

Re: [PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-10 Thread Mathieu Desnoyers
On 2023-12-09 17:50, Steven Rostedt wrote: From: "Steven Rostedt (Google)" Allow a trace write to be as big as the ring buffer tracing data will allow. Currently, it only allows writes of 1KB in size, but there's no reason that it cannot allow what the ring buffer can hold. I would expect

[PATCH] tracing: Allow for max buffer data size trace_marker writes

2023-12-09 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Allow a trace write to be as big as the ring buffer tracing data will allow. Currently, it only allows writes of 1KB in size, but there's no reason that it cannot allow what the ring buffer can hold. Signed-off-by: Steven Rostedt (Google) --- [ Depends on: