Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Tim Chen
On Thu, 2024-02-08 at 10:53 -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > While looking at improving the saved_cmdlines cache I found a huge amount > of wasted memory that should be used for the cmdlines. > > The tracing data saves pids during the trace. At sched switch, if

Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Steven Rostedt
On Mon, 12 Feb 2024 14:08:29 -0800 Tim Chen wrote: > > Now, instead of saving only 128 comms by default, by using this wasted > > space at the end of the structure it can save over 8000 comms and even > > saves space by removing the need for allocating the other array. > > The change looks goo

Re: [PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-12 Thread Tim Chen
On Thu, 2024-02-08 at 10:53 -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > While looking at improving the saved_cmdlines cache I found a huge amount > of wasted memory that should be used for the cmdlines. > > The tracing data saves pids during the trace. At sched switch, if

[PATCH] tracing: Fix wasted memory in saved_cmdlines logic

2024-02-08 Thread Steven Rostedt
From: "Steven Rostedt (Google)" While looking at improving the saved_cmdlines cache I found a huge amount of wasted memory that should be used for the cmdlines. The tracing data saves pids during the trace. At sched switch, if a trace occurred, it will save the comm of the task that did the trac