Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-18 Thread Jann Horn
On Thu, Jun 18, 2020 at 6:42 PM Steven Rostedt wrote: > > On Thu, 18 Jun 2020 01:12:37 +0200 > Jann Horn wrote: > > > static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > > +static ftrace_asm_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > > { > > +#if

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2020 01:12:37 +0200 Jann Horn wrote: > static ftrace_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > +static ftrace_asm_func_t ftrace_ops_get_list_func(struct ftrace_ops *ops) > { > +#if FTRACE_FORCE_LIST_FUNC > + return ftrace_ops_list_func; > +#else > /*

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-18 Thread kernel test robot
Hi Steven, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on tip/perf/core linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-18 Thread kernel test robot
Hi Steven, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on tip/perf/core linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-17 Thread Jann Horn
On Thu, Jun 18, 2020 at 12:36 AM Steven Rostedt wrote: > On Wed, 17 Jun 2020 23:30:07 +0200 > Jann Horn wrote: > > [...] > > > +/* Defined by vmlinux.lds.h see the commment above > > > arch_ftrace_ops_list_func for details */ > > > +void ftrace_ops_list_func(unsigned long ip, unsigned long

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-17 Thread Steven Rostedt
On Wed, 17 Jun 2020 23:30:07 +0200 Jann Horn wrote: > [...] > > +/* Defined by vmlinux.lds.h see the commment above > > arch_ftrace_ops_list_func for details */ > > +void ftrace_ops_list_func(unsigned long ip, unsigned long parent_ip, > > + struct ftrace_ops *op, struct

Re: [PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-17 Thread Jann Horn
On Wed, Jun 17, 2020 at 10:56 PM Steven Rostedt wrote: > In an effort to enable -Wcast-function-type in the top-level Makefile to > support Control Flow Integrity builds, all function casts need to be > removed. > > This means that ftrace_ops_list_func() can no longer be defined as >

[PATCH] tracing: Use linker magic instead of recasting ftrace_ops_list_func()

2020-06-17 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" In an effort to enable -Wcast-function-type in the top-level Makefile to support Control Flow Integrity builds, all function casts need to be removed. This means that ftrace_ops_list_func() can no longer be defined as ftrace_ops_no_ops(). The reason for