Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-02-10 Thread Dongsheng Yang
Hi Steve, As my patch to implement task_nice() as inline function was applied to tip tree. http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=d0ea026808ad81de2af14938448419a95211b938 Please consider to apply this patch in this thread. Thanx :) On 01/23/2014 06:41 AM,

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-02-10 Thread Dongsheng Yang
Hi Steve, As my patch to implement task_nice() as inline function was applied to tip tree. http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=d0ea026808ad81de2af14938448419a95211b938 Please consider to apply this patch in this thread. Thanx :) On 01/23/2014 06:41 AM,

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-23 Thread Steven Rostedt
On Thu, 23 Jan 2014 09:26:30 +0100 Peter Zijlstra wrote: > On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote: > > On 01/22/2014 11:00 PM, Steven Rostedt wrote: > > > > > >Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not > > >include/linux/sched.h > > > > > >Peter,

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-23 Thread Dongsheng Yang
On 01/23/2014 03:26 AM, Peter Zijlstra wrote: On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote: On 01/22/2014 11:00 PM, Steven Rostedt wrote: Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not include/linux/sched.h Peter, is there a reason that task_nice() is not

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-23 Thread Peter Zijlstra
On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote: > On 01/22/2014 11:00 PM, Steven Rostedt wrote: > > > >Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not > >include/linux/sched.h > > > >Peter, is there a reason that task_nice() is not a static inline in > >sched.h

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-23 Thread Peter Zijlstra
On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote: On 01/22/2014 11:00 PM, Steven Rostedt wrote: Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not include/linux/sched.h Peter, is there a reason that task_nice() is not a static inline in sched.h and have these

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-23 Thread Dongsheng Yang
On 01/23/2014 03:26 AM, Peter Zijlstra wrote: On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote: On 01/22/2014 11:00 PM, Steven Rostedt wrote: Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not include/linux/sched.h Peter, is there a reason that task_nice() is not

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-23 Thread Steven Rostedt
On Thu, 23 Jan 2014 09:26:30 +0100 Peter Zijlstra pet...@infradead.org wrote: On Thu, Jan 23, 2014 at 12:11:04PM -0500, Dongsheng Yang wrote: On 01/22/2014 11:00 PM, Steven Rostedt wrote: Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not include/linux/sched.h Peter,

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Dongsheng Yang
On 01/22/2014 11:00 PM, Steven Rostedt wrote: Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not include/linux/sched.h Peter, is there a reason that task_nice() is not a static inline in sched.h and have these macros there too? They only reference fields in task_struct that are

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Steven Rostedt
On Wed, 22 Jan 2014 22:56:32 -0500 Steven Rostedt wrote: > On Wed, 22 Jan 2014 17:41:45 -0500 > Dongsheng Yang wrote: > > > There is already a function named task_nice in sched.h to get the nice value > > of task_struct. We can use it in __update_max_tr() rather than calculate it > > manually.

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Steven Rostedt
On Wed, 22 Jan 2014 17:41:45 -0500 Dongsheng Yang wrote: > There is already a function named task_nice in sched.h to get the nice value > of task_struct. We can use it in __update_max_tr() rather than calculate it > manually. > > Signed-off-by: Dongsheng Yang > --- > kernel/trace/trace.c | 2

[PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Dongsheng Yang
There is already a function named task_nice in sched.h to get the nice value of task_struct. We can use it in __update_max_tr() rather than calculate it manually. Signed-off-by: Dongsheng Yang --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Dongsheng Yang
There is already a function named task_nice in sched.h to get the nice value of task_struct. We can use it in __update_max_tr() rather than calculate it manually. Signed-off-by: Dongsheng Yang yangds.f...@cn.fujitsu.com --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Steven Rostedt
On Wed, 22 Jan 2014 17:41:45 -0500 Dongsheng Yang yangds.f...@cn.fujitsu.com wrote: There is already a function named task_nice in sched.h to get the nice value of task_struct. We can use it in __update_max_tr() rather than calculate it manually. Signed-off-by: Dongsheng Yang

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Steven Rostedt
On Wed, 22 Jan 2014 22:56:32 -0500 Steven Rostedt rost...@goodmis.org wrote: On Wed, 22 Jan 2014 17:41:45 -0500 Dongsheng Yang yangds.f...@cn.fujitsu.com wrote: There is already a function named task_nice in sched.h to get the nice value of task_struct. We can use it in __update_max_tr()

Re: [PATCH] tracing: Use task_nice() in function __update_max_tr() to get the nice value of task.

2014-01-22 Thread Dongsheng Yang
On 01/22/2014 11:00 PM, Steven Rostedt wrote: Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not include/linux/sched.h Peter, is there a reason that task_nice() is not a static inline in sched.h and have these macros there too? They only reference fields in task_struct that are