Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-15 Thread Frank Rowand
On 3/14/19 4:26 PM, Masami Hiramatsu wrote: > Hi Frank and Steve, > > Thank you for pointing it out :) > > On Thu, 14 Mar 2019 18:19:08 -0400 > Steven Rostedt wrote: > >> On Thu, 14 Mar 2019 14:05:02 -0700 >> Frank Rowand wrote: >> >>> Hi Steve, >>> >>> Ping. >> >> Thanks, this got buried. >>

Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-14 Thread Masami Hiramatsu
Hi Frank and Steve, Thank you for pointing it out :) On Thu, 14 Mar 2019 18:19:08 -0400 Steven Rostedt wrote: > On Thu, 14 Mar 2019 14:05:02 -0700 > Frank Rowand wrote: > > > Hi Steve, > > > > Ping. > > Thanks, this got buried. > > > > static int create_dyn_event(int argc, char **argv) >

Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-14 Thread Steven Rostedt
On Thu, 14 Mar 2019 14:05:02 -0700 Frank Rowand wrote: > Hi Steve, > > Ping. Thanks, this got buried. > > static int create_dyn_event(int argc, char **argv) > > { > > struct dyn_event_operations *ops; > > - int ret; > > + int ret = 0; Probably should be ret = -ENODEV; As if ret

Re: [PATCH] tracing: initialize variable in create_dyn_event()

2019-03-14 Thread Frank Rowand
Hi Steve, Ping. -Frank On 1/24/19 6:17 PM, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized > in this function [-Wuninitialized]. > > Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework") > >

[PATCH] tracing: initialize variable in create_dyn_event()

2019-01-24 Thread frowand . list
From: Frank Rowand Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized]. Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework") Signed-off-by: Frank Rowand --- Compile and boot tested only. Please verify the