Re: [PATCH] tracing: use kstrdup_const instead of private implementation

2015-10-01 Thread Steven Rostedt
On Wed, 30 Sep 2015 21:43:00 +0200 Rasmus Villemoes wrote: > On Wed, Sep 09 2015, Rasmus Villemoes wrote: > > ping Thanks for the reminder. I'll take a look at your patches today. -- Steve > > > The kernel now has kstrdup_const/kfree_const for reusing .rodata > > (typically string literals)

Re: [PATCH] tracing: use kstrdup_const instead of private implementation

2015-09-30 Thread Rasmus Villemoes
On Wed, Sep 09 2015, Rasmus Villemoes wrote: ping > The kernel now has kstrdup_const/kfree_const for reusing .rodata > (typically string literals) when possible; there's no reason to > duplicate that logic in the tracing system. Moreover, as the comment > above core_kernel_data states, it may no

[PATCH] tracing: use kstrdup_const instead of private implementation

2015-09-09 Thread Rasmus Villemoes
The kernel now has kstrdup_const/kfree_const for reusing .rodata (typically string literals) when possible; there's no reason to duplicate that logic in the tracing system. Moreover, as the comment above core_kernel_data states, it may not always return true for .rodata - that is for example the ca