Re: [PATCH] trivial: pinctrl core: remove extraneous code lines

2012-08-13 Thread Linus Walleij
On Fri, Aug 10, 2012 at 4:53 PM, Richard Genoud wrote: > In function pinctrl_get_locked, pointer p is returned on error, and also > return on no_error. > So, we just return it with no error test. > > It's pretty the same in function pinctrl_lookup_state_locked: state is > returned in every case,

Re: [PATCH] trivial: pinctrl core: remove extraneous code lines

2012-08-13 Thread Linus Walleij
On Fri, Aug 10, 2012 at 4:53 PM, Richard Genoud richard.gen...@gmail.com wrote: In function pinctrl_get_locked, pointer p is returned on error, and also return on no_error. So, we just return it with no error test. It's pretty the same in function pinctrl_lookup_state_locked: state is

Re: [PATCH] trivial: pinctrl core: remove extraneous code lines

2012-08-10 Thread Stephen Warren
On 08/10/2012 08:53 AM, Richard Genoud wrote: > In function pinctrl_get_locked, pointer p is returned on error, and also > return on no_error. > So, we just return it with no error test. > > It's pretty the same in function pinctrl_lookup_state_locked: state is > returned in every case, so we

[PATCH] trivial: pinctrl core: remove extraneous code lines

2012-08-10 Thread Richard Genoud
In function pinctrl_get_locked, pointer p is returned on error, and also return on no_error. So, we just return it with no error test. It's pretty the same in function pinctrl_lookup_state_locked: state is returned in every case, so we drop the error test and just return state. Signed-off-by:

[PATCH] trivial: pinctrl core: remove extraneous code lines

2012-08-10 Thread Richard Genoud
In function pinctrl_get_locked, pointer p is returned on error, and also return on no_error. So, we just return it with no error test. It's pretty the same in function pinctrl_lookup_state_locked: state is returned in every case, so we drop the error test and just return state. Signed-off-by:

Re: [PATCH] trivial: pinctrl core: remove extraneous code lines

2012-08-10 Thread Stephen Warren
On 08/10/2012 08:53 AM, Richard Genoud wrote: In function pinctrl_get_locked, pointer p is returned on error, and also return on no_error. So, we just return it with no error test. It's pretty the same in function pinctrl_lookup_state_locked: state is returned in every case, so we drop the