Re: [PATCH] tty/nozomi: use pci_iomap instead of ioremap_nocache

2019-02-14 Thread Hugo Lefeuvre
> I will provide a patch if somebody is available to test it. FTR, I have found test devices and should be able to run some tests by the end of next week. regards, Hugo -- Hugo Lefeuvre (hle)|www.owl.eu.com RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD ed25

Re: [PATCH] tty/nozomi: use pci_iomap instead of ioremap_nocache

2019-02-12 Thread Hugo Lefeuvre
(cc-ing Paul Hardwick, mentioned as maintainer of the driver) Hi, > > there's still something unclear to me about dc->card_type being used as > > size argument to ioremap_nocache(). > > > > dc->base_addr is the sum of all six io region lengths, not the size of > > region 0 which we are trying to

Re: [PATCH] tty/nozomi: use pci_iomap instead of ioremap_nocache

2019-02-12 Thread Greg Kroah-Hartman
On Sun, Feb 10, 2019 at 10:45:00PM +0100, Hugo Lefeuvre wrote: > > Use pci_iomap instead of ioremap_nocache in nozomi_card_init(). This > > is a cleaner way to do PCI MMIO (performs additional checks) and > > allows to drop the manual call to pci_resource_start. > > > > pci_iomap relies on ioremap

Re: [PATCH] tty/nozomi: use pci_iomap instead of ioremap_nocache

2019-02-10 Thread Hugo Lefeuvre
> Use pci_iomap instead of ioremap_nocache in nozomi_card_init(). This > is a cleaner way to do PCI MMIO (performs additional checks) and > allows to drop the manual call to pci_resource_start. > > pci_iomap relies on ioremap for MMIO and thus has uncached behavior. there's still something unclea

[PATCH] tty/nozomi: use pci_iomap instead of ioremap_nocache

2019-02-10 Thread Hugo Lefeuvre
Use pci_iomap instead of ioremap_nocache in nozomi_card_init(). This is a cleaner way to do PCI MMIO (performs additional checks) and allows to drop the manual call to pci_resource_start. pci_iomap relies on ioremap for MMIO and thus has uncached behavior. Signed-off-by: Hugo Lefeuvre --- drive