Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-16 Thread Ricardo Ribalda Delgado
Just realized I forgot to add the v2 on the subject. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-16 Thread Ricardo Ribalda Delgado
Introduce an homogeneous lock system between setting and using the rs485 data of the uart_port. This patch should not be split into multiple ones in order to avoid leaving the tree in an unstable state. Suggested-by: Alan Cox Acked-by: Nicolas Ferre Cc: Nicolas Ferre Cc: Greg Kroah-Hartman Cc

Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-13 Thread Nicolas Ferre
On 13/10/2014 21:03, Ricardo Ribalda Delgado : > Hello Nicolas > >> >> I have the feeling that moving the code chunk that uses this new >> variable (rs485_enabled) here ... >> >>> ret = uart_add_one_port(&atmel_uart, &port->uart); >>> if (ret) >>> goto err_add_port; >>> @

Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-13 Thread Ricardo Ribalda Delgado
Hello Nicolas > > I have the feeling that moving the code chunk that uses this new > variable (rs485_enabled) here ... > >> ret = uart_add_one_port(&atmel_uart, &port->uart); >> if (ret) >> goto err_add_port; >> @@ -2574,7 +2572,7 @@ static int atmel_serial_probe(struct p

Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-13 Thread Ricardo Ribalda Delgado
Hello Alan >> + spin_unlock_irqrestore(&port->lock, flags); > > Looks good apart from this bit.. The copy needs to go to a temporary > before the lock is taken otherwise we may sleep on a pagefault with irqs > off > > Alan Good catch I will fix it as you suggest. I will give a give a couple

Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-13 Thread One Thousand Gnomes
> @@ -1154,8 +1154,16 @@ static int uart_get_icount(struct tty_struct *tty, > static int uart_get_rs485_config(struct uart_port *port, >struct serial_rs485 __user *rs485) > { > - if (copy_to_user(rs485, &port->rs485, sizeof(port->rs485))) > + unsigned long flags; >

Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-11 Thread Nicolas Ferre
On 10/10/2014 15:38, Ricardo Ribalda Delgado : > Introduce an homogeneous lock system between setting and using the rs485 > data of the uart_port. > > This patch should not be split into multiple ones in order to avoid > leaving the tree in an unstable state. > > Suggested-by: Alan Cox > Cc: Nic

[PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-10 Thread Ricardo Ribalda Delgado
Introduce an homogeneous lock system between setting and using the rs485 data of the uart_port. This patch should not be split into multiple ones in order to avoid leaving the tree in an unstable state. Suggested-by: Alan Cox Cc: Nicolas Ferre Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: One Tho