Re: [PATCH] tty: Fix low_latency BUG

2014-02-27 Thread One Thousand Gnomes
> > I'm glad to hear that the Bluetooth uart interface is getting > > some use; that means someone will soon be fixing the hard lockup > > in hci_uart_tx_wakeup() reported here: > > I'm not very familiar with the BT devices on our platforms, but most > of them are not using the in-kernel BT driver

Re: [PATCH] tty: Fix low_latency BUG

2014-02-26 Thread Feng Tang
Hi Peter, 2014-02-26 23:40 GMT+08:00 Peter Hurley : > [ +cc linux-bluetooth ] >>> >>> Historically, low_latency was used to force wake-up the reading >>> process rather than wait for the next scheduler tick. The >>> effect was to trim multiple milliseconds of latency from >>> when the process wou

Re: [PATCH] tty: Fix low_latency BUG

2014-02-26 Thread Peter Hurley
[ +cc linux-bluetooth ] Hi Feng, On 02/26/2014 12:11 AM, Feng Tang wrote: Hi Peter, 2014-02-22 20:31 GMT+08:00 Peter Hurley : The user-settable knob, low_latency, has been the source of several BUG reports which stem from flush_to_ldisc() running in interrupt context. Since 3.12, which added

Re: [PATCH] tty: Fix low_latency BUG

2014-02-25 Thread Feng Tang
Hi Peter, 2014-02-22 20:31 GMT+08:00 Peter Hurley : > The user-settable knob, low_latency, has been the source of > several BUG reports which stem from flush_to_ldisc() running > in interrupt context. Since 3.12, which added several sleeping > locks (termios_rwsem and buf->lock) to the input proce

Re: [PATCH] tty: Fix low_latency BUG

2014-02-24 Thread David Sterba
On Sat, Feb 22, 2014 at 07:31:21AM -0500, Peter Hurley wrote: > --- a/drivers/tty/ipwireless/tty.c > +++ b/drivers/tty/ipwireless/tty.c > @@ -176,9 +176,6 @@ void ipwireless_tty_received(struct ipw_tty *tty, > unsigned char *data, > ": %d chars not inserted to flip bu

Re: [PATCH] tty: Fix low_latency BUG

2014-02-22 Thread One Thousand Gnomes
> Remove the low_latency rx steering from tty_flip_buffer_push(); > however, leave the knob as an optional hint to drivers that can > tune their rx fifos and such like. Cleanup stale code comments > regarding low_latency. > > [1] https://lkml.org/lkml/2014/2/20/434 > > Reported-by: Beat Bolli >

[PATCH] tty: Fix low_latency BUG

2014-02-22 Thread Peter Hurley
The user-settable knob, low_latency, has been the source of several BUG reports which stem from flush_to_ldisc() running in interrupt context. Since 3.12, which added several sleeping locks (termios_rwsem and buf->lock) to the input processing path, the frequency of these BUG reports has increased.