Re: [PATCH] tty: Prevent deadlock in n_gsm driver

2013-03-02 Thread Ben Hutchings
I'm looking at commit 4d9b109060f690f5c835130ff54165ae157b3087 ('tty: Prevent deadlock in n_gsm driver') which was cc'd to stable. This drops the tty lock in gsm_dlci_release(). I could apply it to 3.2.y with some adjustment, but I checked the locking context of this function and I think there's

[PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Dirkjan Bussink
This change fixes a deadlock when the multiplexer is closed while there are still client side ports open. When the multiplexer is closed and there are active tty's it tries to close them with tty_vhangup. This has a problem though, because tty_vhangup needs the tty_lock. This patch changes it to u

Re: [PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Dirkjan Bussink
On 30 Jan 2013, at 11:10, Greg Kroah-Hartman wrote: > This patch breaks the build in the tty-next tree: > > drivers/tty/n_gsm.c: In function ‘gsm_dlci_release’: > drivers/tty/n_gsm.c:1713:3: error: too few arguments to function ‘tty_unlock’ > In file included from drivers/tty/n_gsm.c:44:0: > in

Re: [PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Greg Kroah-Hartman
On Wed, Jan 30, 2013 at 10:51:59AM +0100, Dirkjan Bussink wrote: > This change fixes a deadlock when the multiplexer is closed while there > are still client side ports open. > > When the multiplexer is closed and there are active tty's it tries to > close them with tty_vhangup. This has a problem

Re: [PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Greg Kroah-Hartman
On Wed, Jan 30, 2013 at 10:55:00AM +0100, Dirkjan Bussink wrote: > > On 30 Jan 2013, at 06:12, Greg Kroah-Hartman > wrote: > > > It doesn't apply cleanly to the linux-next tree, can you refresh this > > and resend it so that I can apply it? If you want it backported to the > > stable kernel re

Re: [PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Dirkjan Bussink
On 30 Jan 2013, at 06:12, Greg Kroah-Hartman wrote: > It doesn't apply cleanly to the linux-next tree, can you refresh this > and resend it so that I can apply it? If you want it backported to the > stable kernel releases, we can only do that after it gets into Linus's > tree, see the file, Doc

[PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Dirkjan Bussink
This change fixes a deadlock when the multiplexer is closed while there are still client side ports open. When the multiplexer is closed and there are active tty's it tries to close them with tty_vhangup. This has a problem though, because tty_vhangup needs the tty_lock. This patch changes it to u

Re: [PATCH] tty: Prevent deadlock in n_gsm driver

2013-01-30 Thread Greg Kroah-Hartman
On Tue, Jan 29, 2013 at 09:49:52AM +0100, Dirkjan Bussink wrote: > This change fixes a deadlock when the multiplexer is closed while there > are still client side ports open. > > When the multiplexer is closed and there are active tty's it tries to > close them with tty_vhangup. This has a problem