Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-09 Thread Andy Shevchenko
On Tue, Feb 9, 2016 at 2:10 PM, Mathieu OTHACEHE wrote: >> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In >> which case why not to use 8250_core.c / 8250_port.c and entire 8250/ >> infrastructure? > > Well, the vendor is providing two drivers for his serial pci cards :

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-09 Thread Mathieu OTHACEHE
> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In > which case why not to use 8250_core.c / 8250_port.c and entire 8250/ > infrastructure? Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie. The mxser driver has been cleaned up and

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-09 Thread Mathieu OTHACEHE
> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In > which case why not to use 8250_core.c / 8250_port.c and entire 8250/ > infrastructure? Well, the vendor is providing two drivers for his serial pci cards : mxser and mxupcie. The mxser driver has been cleaned up and

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-09 Thread Andy Shevchenko
On Tue, Feb 9, 2016 at 2:10 PM, Mathieu OTHACEHE wrote: >> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In >> which case why not to use 8250_core.c / 8250_port.c and entire 8250/ >> infrastructure? > > Well, the vendor is providing two drivers for his

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-08 Thread Andy Shevchenko
On Mon, Feb 1, 2016 at 10:34 PM, Mathieu OTHACEHE wrote: > Add a driver which supports: > > - CP-102E: 2 ports RS232 PCIE card > - CP-102EL: 2 ports RS232 PCIE card > - CP-132EL: 2 ports RS422/485 PCIE card > - CP-114EL: 4 ports RS232/422/485 PCIE card > - CP-104EL-A: 4 ports RS232 PCIE card > -

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-08 Thread Andy Shevchenko
On Mon, Feb 1, 2016 at 10:34 PM, Mathieu OTHACEHE wrote: > Add a driver which supports: > > - CP-102E: 2 ports RS232 PCIE card > - CP-102EL: 2 ports RS232 PCIE card > - CP-132EL: 2 ports RS422/485 PCIE card > - CP-114EL: 4 ports RS232/422/485 PCIE card > - CP-104EL-A: 4

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-07 Thread kbuild test robot
Hi Mathieu, [auto build test ERROR on tty/tty-testing] [also build test ERROR on v4.5-rc2 next-20160205] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-07 Thread kbuild test robot
Hi Mathieu, [auto build test ERROR on tty/tty-testing] [also build test ERROR on v4.5-rc2 next-20160205] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-03 Thread Mathieu OTHACEHE
Thank you for your comments. I'll come up with v2 soon but, I have a question about this point : > > + /* clear Rx/Tx FIFO's */ > > + for (i = 0; i < reset_cnt; i++) { > > + iowrite8((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), > > +

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-03 Thread Mathieu OTHACEHE
Thank you for your comments. I'll come up with v2 soon but, I have a question about this point : > > + /* clear Rx/Tx FIFO's */ > > + for (i = 0; i < reset_cnt; i++) { > > + iowrite8((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), > > +

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-01 Thread One Thousand Gnomes
> Here is a new driver for MOXA Smartio MUE cards. It is based > on the vendor driver available on MOXA website and on the > mainline mxser driver. > > I was able to test it on a CP-168EL-A card on PC. Some of the > cards (118E-A, 138E-A, 134EL-A, 116E-A-A et 116E-A-B) have > a CPLD module

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-01 Thread Greg KH
On Mon, Feb 01, 2016 at 09:34:19PM +0100, Mathieu OTHACEHE wrote: > Add a driver which supports: > > - CP-102E: 2 ports RS232 PCIE card > - CP-102EL: 2 ports RS232 PCIE card > - CP-132EL: 2 ports RS422/485 PCIE card > - CP-114EL: 4 ports RS232/422/485 PCIE card > - CP-104EL-A: 4 ports RS232 PCIE

[PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-01 Thread Mathieu OTHACEHE
Add a driver which supports: - CP-102E: 2 ports RS232 PCIE card - CP-102EL: 2 ports RS232 PCIE card - CP-132EL: 2 ports RS422/485 PCIE card - CP-114EL: 4 ports RS232/422/485 PCIE card - CP-104EL-A: 4 ports RS232 PCIE card - CP-168EL-A: 8 ports RS232 PCIE card - CP-118EL-A: 8 ports RS232/422/485

[PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-01 Thread Mathieu OTHACEHE
Add a driver which supports: - CP-102E: 2 ports RS232 PCIE card - CP-102EL: 2 ports RS232 PCIE card - CP-132EL: 2 ports RS422/485 PCIE card - CP-114EL: 4 ports RS232/422/485 PCIE card - CP-104EL-A: 4 ports RS232 PCIE card - CP-168EL-A: 8 ports RS232 PCIE card - CP-118EL-A: 8 ports RS232/422/485

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-01 Thread Greg KH
On Mon, Feb 01, 2016 at 09:34:19PM +0100, Mathieu OTHACEHE wrote: > Add a driver which supports: > > - CP-102E: 2 ports RS232 PCIE card > - CP-102EL: 2 ports RS232 PCIE card > - CP-132EL: 2 ports RS422/485 PCIE card > - CP-114EL: 4 ports RS232/422/485 PCIE card > - CP-104EL-A: 4 ports RS232 PCIE

Re: [PATCH] tty: add Moxa Smartio MUE serial driver

2016-02-01 Thread One Thousand Gnomes
> Here is a new driver for MOXA Smartio MUE cards. It is based > on the vendor driver available on MOXA website and on the > mainline mxser driver. > > I was able to test it on a CP-168EL-A card on PC. Some of the > cards (118E-A, 138E-A, 134EL-A, 116E-A-A et 116E-A-B) have > a CPLD module