RE: [PATCH] tty: amba-pl011: use sg_table instead of scatterlist

> > @@ -344,17 +344,23 @@ static int pl011_sgbuf_init(struct dma_chan *chan, > struct pl011_sgbuf *sg, > > enum dma_data_direction dir) > > { > > dma_addr_t dma_addr; > > + int ret; > > > > sg->buf = dma_alloc_coherent(chan->device->dev, > > PL011_DMA_BUFFER_SIZE, &dma_ad

Re: [PATCH] tty: amba-pl011: use sg_table instead of scatterlist

On Tue, Mar 08, 2016 at 11:43:36AM +0900, Chanho Min wrote: > The use of phys_to_page is wrong in commit cb06ff102e2d ("ARM: PL011: > Add support for Rx DMA buffer polling."), beacase DMA address is not > physical address. Also, phys_to_page is not declared in some architecture. > The use of virt_t

[PATCH] tty: amba-pl011: use sg_table instead of scatterlist

The use of phys_to_page is wrong in commit cb06ff102e2d ("ARM: PL011: Add support for Rx DMA buffer polling."), beacase DMA address is not physical address. Also, phys_to_page is not declared in some architecture. The use of virt_to_page is wrong as well because dma_alloc_coherent implementaion are