Looks good to me. I'd have only kept a pointer to the struct module,
but that shouldn't matter for the actual code generated.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Christoph Hellwig <[EMAIL PROTECTED]>
release_mem contains two copies of exactly the same code. Refactor
these into a new helper, release_tty. The only change in behaviour
is that the driver reference count is now decremented after the
master tty has been freed instead of before.
[EMAIL
From: Christoph Hellwig [EMAIL PROTECTED]
release_mem contains two copies of exactly the same code. Refactor
these into a new helper, release_tty. The only change in behaviour
is that the driver reference count is now decremented after the
master tty has been freed instead of before.
[EMAIL
Looks good to me. I'd have only kept a pointer to the struct module,
but that shouldn't matter for the actual code generated.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On 1/30/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
BUG: unable to handle kernel paging request at virtual address 6b6b6bdf
Use after free. The new code does module_put() _after_
free_tty_struct() which is obviously wrong.
-
To unsubscribe from this list: send the line "unsubscribe
On Mon, 29 Jan 2007 14:06:04 -0500
Alan Cox <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 29, 2007 at 07:12:35PM +0100, Christoph Hellwig wrote:
> > Okay. Now that we get into the details I've also added some renaming,
> > release_mem becomes release_tty and the new factored out function is
> >
On Mon, Jan 29, 2007 at 07:12:35PM +0100, Christoph Hellwig wrote:
> Okay. Now that we get into the details I've also added some renaming,
> release_mem becomes release_tty and the new factored out function is
> release_one_tty. The difference is documented in the kdoc comments.
>
>
>
On Mon, Jan 29, 2007 at 07:01:00AM -0500, Alan Cox wrote:
> On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
> > release_mem contains two copies of exactly the same code. Refactor
> > these into a new helper, release_tty. The only change in behaviour
> > is that the driver
On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
> release_mem contains two copies of exactly the same code. Refactor
> these into a new helper, release_tty. The only change in behaviour
> is that the driver reference count is now decremented after the
> master tty has been
On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
release_mem contains two copies of exactly the same code. Refactor
these into a new helper, release_tty. The only change in behaviour
is that the driver reference count is now decremented after the
master tty has been freed
On Mon, Jan 29, 2007 at 07:01:00AM -0500, Alan Cox wrote:
On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
release_mem contains two copies of exactly the same code. Refactor
these into a new helper, release_tty. The only change in behaviour
is that the driver reference
On Mon, Jan 29, 2007 at 07:12:35PM +0100, Christoph Hellwig wrote:
Okay. Now that we get into the details I've also added some renaming,
release_mem becomes release_tty and the new factored out function is
release_one_tty. The difference is documented in the kdoc comments.
Signed-off-by:
On Mon, 29 Jan 2007 14:06:04 -0500
Alan Cox [EMAIL PROTECTED] wrote:
On Mon, Jan 29, 2007 at 07:12:35PM +0100, Christoph Hellwig wrote:
Okay. Now that we get into the details I've also added some renaming,
release_mem becomes release_tty and the new factored out function is
On 1/30/07, Andrew Morton [EMAIL PROTECTED] wrote:
BUG: unable to handle kernel paging request at virtual address 6b6b6bdf
Use after free. The new code does module_put() _after_
free_tty_struct() which is obviously wrong.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
release_mem contains two copies of exactly the same code. Refactor
these into a new helper, release_tty. The only change in behaviour
is that the driver reference count is now decremented after the
master tty has been freed instead of before.
Signed-off-by: Christoph Hellwig <[EMAIL
release_mem contains two copies of exactly the same code. Refactor
these into a new helper, release_tty. The only change in behaviour
is that the driver reference count is now decremented after the
master tty has been freed instead of before.
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
16 matches
Mail list logo