Re: Re: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-11-05 Thread taoyuhong
Hi Greg >How is things crashing on startup when you are messing with data being sent on >shutdown? >Are you still sending data at startup time? Yes, I always sending data at startup. Actually I keep sending "reboot" to serial port, all the time, no break, regardless of any response from system.

Re: 答复: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-11-03 Thread gre...@linuxfoundation.org
On Fri, Nov 03, 2017 at 10:48:04AM +, taoyuhong wrote: > Hi Alan > > Serial tty oops on real arm computer. > > That is Hikey960 board, with 8 cortex-a57 cpus and pl011 serial hardware. > Debian8 is pre-installed, and I replaced the kernel with linux-stable 4.13.10. > > It is very easy to tri

答复: 答复: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-10-27 Thread taoyuhong
Hi Gerg > Because of this text, I am not allowed to respond to your emails, sorry :( That is my fault! Please let me re-send these message. > This feels "odd", are we sure that open really should be clearning this flag? Because the pty devices also use tty_init_dev(), to create tty_struct , and

Re: 答复: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-10-27 Thread Greg KH
On Thu, Oct 26, 2017 at 12:10:20PM +, taoyuhong wrote: > 本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁 > 止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中 > 的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件! > This e-mail and its attachments contain confidential information from HUAWEI, > which > is intended only for the

Re: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-10-26 Thread Alan Cox
> I can reproduce this problem on CentOS now. It seems better to leave this > problem to drivers, not the user process. > Do you think we should examine serial drivers of ARM, like pl011? Can you reproduce it on real hardware - I ask because the driver has been around for years without reports an

Re: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-10-25 Thread Alan Cox
> When tty_open() is opening a serial tty at the first time, after > alloc_tty_struct() is called, before tty->ops->open() is finished. That's kind of unavoidable. > Serial driever like pl011 on ARM is ready to setup kworker threads > to receive data with flush_to_ldisc(). Serial input at this ti

Re: [PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-10-25 Thread Greg KH
On Wed, Oct 25, 2017 at 10:15:35AM +0800, taoyuhong wrote: > From: Yuhong Tao > > When tty_open() is opening a serial tty at the first time, after > alloc_tty_struct() is called, before tty->ops->open() is finished. > Serial driever like pl011 on ARM is ready to setup kworker threads > to receive

[PATCH] tty: fix flush_to_ldisc() oops before tty_open is done

2017-10-24 Thread taoyuhong
From: Yuhong Tao When tty_open() is opening a serial tty at the first time, after alloc_tty_struct() is called, before tty->ops->open() is finished. Serial driever like pl011 on ARM is ready to setup kworker threads to receive data with flush_to_ldisc(). Serial input at this time window can trigg