Re: [PATCH] tty: max3100: remove unused variable rts and remove unused assignment

2017-11-02 Thread walter harms
Am 02.11.2017 15:22, schrieb Colin Ian King: > On 02/11/17 14:21, Colin Ian King wrote: >> On 02/11/17 14:14, walter harms wrote: >>> >>> >>> Am 02.11.2017 15:01, schrieb Colin King: From: Colin Ian King Variable rts is being assigned but it is never read, hence it can be rem

Re: [PATCH] tty: max3100: remove unused variable rts and remove unused assignment

2017-11-02 Thread Colin Ian King
On 02/11/17 14:21, Colin Ian King wrote: > On 02/11/17 14:14, walter harms wrote: >> >> >> Am 02.11.2017 15:01, schrieb Colin King: >>> From: Colin Ian King >>> >>> Variable rts is being assigned but it is never read, hence it can be >>> removed. The assignment to param_new to zero is redundant a

Re: [PATCH] tty: max3100: remove unused variable rts and remove unused assignment

2017-11-02 Thread Colin Ian King
On 02/11/17 14:14, walter harms wrote: > > > Am 02.11.2017 15:01, schrieb Colin King: >> From: Colin Ian King >> >> Variable rts is being assigned but it is never read, hence it can be >> removed. The assignment to param_new to zero is redundant as it is >> being updates a few statements later,

Re: [PATCH] tty: max3100: remove unused variable rts and remove unused assignment

2017-11-02 Thread walter harms
Am 02.11.2017 15:01, schrieb Colin King: > From: Colin Ian King > > Variable rts is being assigned but it is never read, hence it can be > removed. The assignment to param_new to zero is redundant as it is > being updates a few statements later, so remove this redundant > assignment. Cleans up

[PATCH] tty: max3100: remove unused variable rts and remove unused assignment

2017-11-02 Thread Colin King
From: Colin Ian King Variable rts is being assigned but it is never read, hence it can be removed. The assignment to param_new to zero is redundant as it is being updates a few statements later, so remove this redundant assignment. Cleans up two clang warnings: drivers/tty/serial/max3100.c:277: