Re: [PATCH] tty: serial: 8250: Fix type field in format string

2019-04-27 Thread Greg KH
On Sat, Apr 27, 2019 at 04:41:44PM +0800, Hao Lee wrote: > On Sat, 27 Apr 2019 at 16:09, Greg KH wrote: > > > > On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote: > > > The variable type and the type field is inconsistent. > > > > In what way? Please be very specific when you resend this.

Re: [PATCH] tty: serial: 8250: Fix type field in format string

2019-04-27 Thread Hao Lee
On Sat, 27 Apr 2019 at 16:09, Greg KH wrote: > > On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote: > > The variable type and the type field is inconsistent. > > In what way? Please be very specific when you resend this. The main problem is the dev_dbg statement should print the value of

Re: [PATCH] tty: serial: 8250: Fix type field in format string

2019-04-27 Thread Greg KH
On Sat, Apr 27, 2019 at 04:00:15PM +0800, Hao Lee wrote: > The variable type and the type field is inconsistent. In what way? Please be very specific when you resend this. thanks, greg k-h

[PATCH] tty: serial: 8250: Fix type field in format string

2019-04-27 Thread Hao Lee
The variable type and the type field is inconsistent. Signed-off-by: Hao Lee --- drivers/tty/serial/8250/8250_pnp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pnp.c b/drivers/tty/serial/8250/8250_pnp.c index 431e69a5a6a0..9dea11baf479