RE: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Anson Huang
> On Wed, Oct 09, 2019 at 11:12:20AM +0300, Andy Shevchenko wrote: > > On Wed, Oct 9, 2019 at 9:53 AM Uwe Kleine-König > > wrote: > > > > > The patch is fine given the changed behaviour of platform_get_irq. I > > > wonder if it is sensible to introduce a variant of platform_get_irq > > > (say >

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Uwe Kleine-König
On Wed, Oct 09, 2019 at 11:12:20AM +0300, Andy Shevchenko wrote: > On Wed, Oct 9, 2019 at 9:53 AM Uwe Kleine-König > wrote: > > > The patch is fine given the changed behaviour of platform_get_irq. I > > wonder if it is sensible to introduce a variant of platform_get_irq (say > > platform_get_irq_

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Andy Shevchenko
On Wed, Oct 9, 2019 at 9:53 AM Uwe Kleine-König wrote: > The patch is fine given the changed behaviour of platform_get_irq. I > wonder if it is sensible to introduce a variant of platform_get_irq (say > platform_get_irq_nowarn) that behaves like __platform_get_irq does > today. Then the imx drive

RE: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Anson Huang
Hi, Uwe > On Wed, Oct 09, 2019 at 07:24:57AM +, Anson Huang wrote: > > > On Wed, Oct 09, 2019 at 06:58:24AM +, Anson Huang wrote: > > > > > The patch is fine given the changed behaviour of > > > > > platform_get_irq. I wonder if it is sensible to introduce a > > > > > variant of platform_g

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Uwe Kleine-König
On Wed, Oct 09, 2019 at 07:24:57AM +, Anson Huang wrote: > > On Wed, Oct 09, 2019 at 06:58:24AM +, Anson Huang wrote: > > > > The patch is fine given the changed behaviour of platform_get_irq. I > > > > wonder if it is sensible to introduce a variant of platform_get_irq (say > > > > platfor

RE: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Anson Huang
Hi, Uwe > On Wed, Oct 09, 2019 at 06:58:24AM +, Anson Huang wrote: > > > On Wed, Oct 09, 2019 at 02:18:31PM +0800, Anson Huang wrote: > > > > All i.MX SoCs except i.MX1 have ONLY 1 IRQ, so it is better to > > > > check the IRQ count before getting second/third IRQ to avoid below > > > > error

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-09 Thread Uwe Kleine-König
Hello, On Wed, Oct 09, 2019 at 06:58:24AM +, Anson Huang wrote: > > On Wed, Oct 09, 2019 at 02:18:31PM +0800, Anson Huang wrote: > > > All i.MX SoCs except i.MX1 have ONLY 1 IRQ, so it is better to check > > > the IRQ count before getting second/third IRQ to avoid below error > > > message dur

RE: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-08 Thread Anson Huang
Hi, Uwe > On Wed, Oct 09, 2019 at 02:18:31PM +0800, Anson Huang wrote: > > All i.MX SoCs except i.MX1 have ONLY 1 IRQ, so it is better to check > > the IRQ count before getting second/third IRQ to avoid below error > > message during probe: > > > > [0.726219] imx-uart 3086.serial: IRQ inde

Re: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-08 Thread Uwe Kleine-König
Hello, On Wed, Oct 09, 2019 at 02:18:31PM +0800, Anson Huang wrote: > All i.MX SoCs except i.MX1 have ONLY 1 IRQ, so it is better to check > the IRQ count before getting second/third IRQ to avoid below error > message during probe: > > [0.726219] imx-uart 3086.serial: IRQ index 1 not foun

[PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

2019-10-08 Thread Anson Huang
All i.MX SoCs except i.MX1 have ONLY 1 IRQ, so it is better to check the IRQ count before getting second/third IRQ to avoid below error message during probe: [0.726219] imx-uart 3086.serial: IRQ index 1 not found [0.731329] imx-uart 3086.serial: IRQ index 2 not found Signed-off-by