Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-10 Thread Greg Kroah-Hartman
On Wed, Sep 10, 2014 at 08:07:24AM +0200, Johannes Thumshirn wrote: > On Tue, Sep 09, 2014 at 05:26:35PM -0700, Greg Kroah-Hartman wrote: > > On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote: > > > On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: > > > > > > >

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-10 Thread Johannes Thumshirn
On Tue, Sep 09, 2014 at 05:26:35PM -0700, Greg Kroah-Hartman wrote: > On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote: > > On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: > > > > > > > > @@ -118,6 +117,10 @@ static int align; > > > > module_param(align, int,

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-10 Thread Johannes Thumshirn
On Tue, Sep 09, 2014 at 05:26:35PM -0700, Greg Kroah-Hartman wrote: On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote: On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: @@ -118,6 +117,10 @@ static int align; module_param(align, int, S_IRUGO);

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-10 Thread Greg Kroah-Hartman
On Wed, Sep 10, 2014 at 08:07:24AM +0200, Johannes Thumshirn wrote: On Tue, Sep 09, 2014 at 05:26:35PM -0700, Greg Kroah-Hartman wrote: On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote: On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: @@ -118,6

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-09 Thread Greg Kroah-Hartman
On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote: > On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: > > > > > > @@ -118,6 +117,10 @@ static int align; > > > module_param(align, int, S_IRUGO); > > > MODULE_PARM_DESC(align, "Keep hardware FIFO write pointer

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-09 Thread Greg Kroah-Hartman
On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote: On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: @@ -118,6 +117,10 @@ static int align; module_param(align, int, S_IRUGO); MODULE_PARM_DESC(align, Keep hardware FIFO write pointer aligned,

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-08 Thread Johannes Thumshirn
On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: > > > > @@ -118,6 +117,10 @@ static int align; > > module_param(align, int, S_IRUGO); > > MODULE_PARM_DESC(align, "Keep hardware FIFO write pointer aligned, default > > 0"); > > > > +static int rx_timeout; > >

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-08 Thread Greg Kroah-Hartman
On Thu, Aug 28, 2014 at 02:32:20PM +0200, Johannes Thumshirn wrote: > 16z135 IP Core has changed so the driver needs to be updated to respect > these changes. The following changes have been made: > > * Don't invert the 16z135 modem status register when reading. > * Add module parameter to

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-08 Thread Greg Kroah-Hartman
On Thu, Aug 28, 2014 at 02:32:20PM +0200, Johannes Thumshirn wrote: 16z135 IP Core has changed so the driver needs to be updated to respect these changes. The following changes have been made: * Don't invert the 16z135 modem status register when reading. * Add module parameter to configure

Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-09-08 Thread Johannes Thumshirn
On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote: @@ -118,6 +117,10 @@ static int align; module_param(align, int, S_IRUGO); MODULE_PARM_DESC(align, Keep hardware FIFO write pointer aligned, default 0); +static int rx_timeout; +module_param(rx_timeout, uint,

[PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-08-28 Thread Johannes Thumshirn
16z135 IP Core has changed so the driver needs to be updated to respect these changes. The following changes have been made: * Don't invert the 16z135 modem status register when reading. * Add module parameter to configure the (baud rate dependent) RX timeout. Character timeout in seconds =

[PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

2014-08-28 Thread Johannes Thumshirn
16z135 IP Core has changed so the driver needs to be updated to respect these changes. The following changes have been made: * Don't invert the 16z135 modem status register when reading. * Add module parameter to configure the (baud rate dependent) RX timeout. Character timeout in seconds =